github-actions[bot] commented on code in PR #16812:
URL: https://github.com/apache/doris/pull/16812#discussion_r1108373958
##########
be/src/olap/tablet.cpp:
##########
@@ -1823,6 +1824,24 @@ Status
Tablet::_write_cooldown_meta(io::RemoteFileSystem* fs, UniqueId cooldown_
new_rs_meta->start_version() !=
cooldowned_rs_metas.back()->end_version() + 1)) {
return Status::InternalError("version not continuous");
}
+
+ // check_version_continuity
+ if (!cooldowned_rs_metas.empty()) {
+ RowsetMetaSharedPtr prev_rowset = cooldowned_rs_metas.front();
+ for (size_t i = 1; i < cooldowned_rs_metas.size(); ++i) {
+ RowsetMetaSharedPtr rowset_meta = cooldowned_rs_metas[i];
Review Comment:
warning: no viable conversion from 'shared_ptr<doris::RowsetMeta>' to
'shared_ptr<doris::Rowset>' [clang-diagnostic-error]
```cpp
ldowned_rs_metas.size(); ++i) {
^
```
**/usr/include/c++/11/bits/shared_ptr.h:149:** candidate constructor not
viable: no known conversion from
'__gnu_cxx::__alloc_traits<std::allocator<std::shared_ptr<doris::RowsetMeta>>,
std::shared_ptr<doris::RowsetMeta>>::value_type' (aka
'std::shared_ptr<doris::RowsetMeta>') to 'const std::shared_ptr<doris::Rowset>
&' for 1st argument
```cpp
shared_ptr(const shared_ptr&) noexcept = default; ///< Copy constructor
^
```
**/usr/include/c++/11/bits/shared_ptr.h:303:** candidate constructor not
viable: no known conversion from
'__gnu_cxx::__alloc_traits<std::allocator<std::shared_ptr<doris::RowsetMeta>>,
std::shared_ptr<doris::RowsetMeta>>::value_type' (aka
'std::shared_ptr<doris::RowsetMeta>') to 'std::shared_ptr<doris::Rowset> &&'
for 1st argument
```cpp
shared_ptr(shared_ptr&& __r) noexcept
^
```
**/usr/include/c++/11/bits/shared_ptr.h:356:** candidate constructor not
viable: no known conversion from
'__gnu_cxx::__alloc_traits<std::allocator<std::shared_ptr<doris::RowsetMeta>>,
std::shared_ptr<doris::RowsetMeta>>::value_type' (aka
'std::shared_ptr<doris::RowsetMeta>') to 'std::nullptr_t' for 1st argument
```cpp
constexpr shared_ptr(nullptr_t) noexcept : shared_ptr() { }
^
```
**/usr/include/c++/11/bits/shared_ptr.h:295:** candidate template ignored:
requirement 'is_constructible<std::__shared_ptr<doris::Rowset,
__gnu_cxx::_S_atomic>, const std::shared_ptr<doris::RowsetMeta> &>::value' was
not satisfied [with _Yp = doris::RowsetMeta]
```cpp
shared_ptr(const shared_ptr<_Yp>& __r) noexcept
^
```
**/usr/include/c++/11/bits/shared_ptr.h:312:** candidate template ignored:
requirement 'is_constructible<std::__shared_ptr<doris::Rowset,
__gnu_cxx::_S_atomic>, std::shared_ptr<doris::RowsetMeta>>::value' was not
satisfied [with _Yp = doris::RowsetMeta]
```cpp
shared_ptr(shared_ptr<_Yp>&& __r) noexcept
^
```
**/usr/include/c++/11/bits/shared_ptr.h:331:** candidate template ignored:
could not match 'auto_ptr' against 'shared_ptr'
```cpp
shared_ptr(auto_ptr<_Yp>&& __r);
^
```
**/usr/include/c++/11/bits/shared_ptr.h:339:** candidate template ignored:
could not match 'unique_ptr' against 'shared_ptr'
```cpp
shared_ptr(unique_ptr<_Yp, _Del>&& __r)
^
```
**/usr/include/c++/11/bits/shared_ptr.h:407:** candidate template ignored:
could not match '_Sp_alloc_shared_tag' against 'shared_ptr'
```cpp
shared_ptr(_Sp_alloc_shared_tag<_Alloc> __tag, _Args&&... __args)
^
```
**/usr/include/c++/11/bits/shared_ptr.h:159:** explicit constructor is not a
candidate
```cpp
shared_ptr(_Yp* __p) : __shared_ptr<_Tp>(__p) { }
^
```
**/usr/include/c++/11/bits/shared_ptr.h:324:** explicit constructor is not a
candidate
```cpp
explicit shared_ptr(const weak_ptr<_Yp>& __r)
^
```
##########
be/src/olap/tablet.cpp:
##########
@@ -1823,6 +1824,24 @@ Status
Tablet::_write_cooldown_meta(io::RemoteFileSystem* fs, UniqueId cooldown_
new_rs_meta->start_version() !=
cooldowned_rs_metas.back()->end_version() + 1)) {
return Status::InternalError("version not continuous");
}
+
+ // check_version_continuity
+ if (!cooldowned_rs_metas.empty()) {
+ RowsetMetaSharedPtr prev_rowset = cooldowned_rs_metas.front();
Review Comment:
warning: no viable conversion from 'shared_ptr<doris::RowsetMeta>' to
'shared_ptr<doris::Rowset>' [clang-diagnostic-error]
```cpp
!cooldowned_rs_metas.empty()) {
^
```
**/usr/include/c++/11/bits/shared_ptr.h:149:** candidate constructor not
viable: no known conversion from
'__gnu_cxx::__alloc_traits<std::allocator<std::shared_ptr<doris::RowsetMeta>>,
std::shared_ptr<doris::RowsetMeta>>::value_type' (aka
'std::shared_ptr<doris::RowsetMeta>') to 'const std::shared_ptr<doris::Rowset>
&' for 1st argument
```cpp
shared_ptr(const shared_ptr&) noexcept = default; ///< Copy constructor
^
```
**/usr/include/c++/11/bits/shared_ptr.h:303:** candidate constructor not
viable: no known conversion from
'__gnu_cxx::__alloc_traits<std::allocator<std::shared_ptr<doris::RowsetMeta>>,
std::shared_ptr<doris::RowsetMeta>>::value_type' (aka
'std::shared_ptr<doris::RowsetMeta>') to 'std::shared_ptr<doris::Rowset> &&'
for 1st argument
```cpp
shared_ptr(shared_ptr&& __r) noexcept
^
```
**/usr/include/c++/11/bits/shared_ptr.h:356:** candidate constructor not
viable: no known conversion from
'__gnu_cxx::__alloc_traits<std::allocator<std::shared_ptr<doris::RowsetMeta>>,
std::shared_ptr<doris::RowsetMeta>>::value_type' (aka
'std::shared_ptr<doris::RowsetMeta>') to 'std::nullptr_t' for 1st argument
```cpp
constexpr shared_ptr(nullptr_t) noexcept : shared_ptr() { }
^
```
**/usr/include/c++/11/bits/shared_ptr.h:295:** candidate template ignored:
requirement 'is_constructible<std::__shared_ptr<doris::Rowset,
__gnu_cxx::_S_atomic>, const std::shared_ptr<doris::RowsetMeta> &>::value' was
not satisfied [with _Yp = doris::RowsetMeta]
```cpp
shared_ptr(const shared_ptr<_Yp>& __r) noexcept
^
```
**/usr/include/c++/11/bits/shared_ptr.h:312:** candidate template ignored:
requirement 'is_constructible<std::__shared_ptr<doris::Rowset,
__gnu_cxx::_S_atomic>, std::shared_ptr<doris::RowsetMeta>>::value' was not
satisfied [with _Yp = doris::RowsetMeta]
```cpp
shared_ptr(shared_ptr<_Yp>&& __r) noexcept
^
```
**/usr/include/c++/11/bits/shared_ptr.h:331:** candidate template ignored:
could not match 'auto_ptr' against 'shared_ptr'
```cpp
shared_ptr(auto_ptr<_Yp>&& __r);
^
```
**/usr/include/c++/11/bits/shared_ptr.h:339:** candidate template ignored:
could not match 'unique_ptr' against 'shared_ptr'
```cpp
shared_ptr(unique_ptr<_Yp, _Del>&& __r)
^
```
**/usr/include/c++/11/bits/shared_ptr.h:407:** candidate template ignored:
could not match '_Sp_alloc_shared_tag' against 'shared_ptr'
```cpp
shared_ptr(_Sp_alloc_shared_tag<_Alloc> __tag, _Args&&... __args)
^
```
**/usr/include/c++/11/bits/shared_ptr.h:159:** explicit constructor is not a
candidate
```cpp
shared_ptr(_Yp* __p) : __shared_ptr<_Tp>(__p) { }
^
```
**/usr/include/c++/11/bits/shared_ptr.h:324:** explicit constructor is not a
candidate
```cpp
explicit shared_ptr(const weak_ptr<_Yp>& __r)
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
