abhinav-phi commented on PR #68732: URL: https://github.com/apache/doris/pull/68732#issuecomment-6220159249
@morrySnow the finding from the review is addressed at 80577b45, the folded NULL keeps `VarcharType.SYSTEM_DEFAULT` and the test asserts the data type on both the negative and the positive case. two things I cannot do on this branch myself: your earlier approval was dismissed by the push, so it needs a fresh +1, and the GitHub Actions runs on this head are still at action_required with no jobs, which I cannot approve as a first time contributor. `run buildall` on 80577b45 would also be useful, because the FE UT failure that showed up on the previous head 1b7be576 was in this same area and I want to see it clear on the current head rather than assume it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
