re20052 commented on PR #68042: URL: https://github.com/apache/doris/pull/68042#issuecomment-6206440685
> This finding is an example of over-review. The current code correctly handles recoverable Exceptions. An Error generally indicates that the FE JVM is already in a severely unhealthy state, so special handling of its wrapping or propagation provides little practical value. Moreover, Doris already catches Throwable at higher-level boundaries, so rethrowing the original Error does not establish meaningfully different process-level behavior. This should not be treated as a P1 blocker for this PR. This finding is an example of over-review. The current code correctly handles recoverable Exceptions. An Error generally indicates that the FE JVM is already in a severely unhealthy state, so special handling of its wrapping or propagation provides little practical value. Moreover, Doris already catches Throwable at higher-level boundaries, so rethrowing the original Error does not establish meaningfully different process-level behavior. This should not be treated as a P1 blocker for this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
