morningman opened a new pull request, #4327:
URL: https://github.com/apache/doris-website/pull/4327

   ## Summary
   
   Fix the localized publishing check that failed in [Cron Deploy 
#38699855388](https://github.com/apache/doris-website/actions/runs/38699855388),
 together with the broken documentation search reported on the [Dev Index 
Overview 
page](https://doris.apache.org/docs/dev/table-design/index/index-overview/).
   
   - Parse Markdown directives before assigning localized heading IDs, matching 
Docusaurus. The BI FAQ heading contains `error:protocol`; the previous parser 
included `protocol` in the Japanese anchor although Docusaurus excludes it from 
the English anchor. Keep the existing parse for persisted technical and 
semantic fingerprints so existing translation state remains compatible.
   - Import search `language` from `proxiedGeneratedConstants`, where the 
plugin exports it. Importing it from `proxiedGenerated` produced `undefined`, 
so both the search dropdown and full search page threw `Cannot read properties 
of undefined (reading 'length')` after loading their indexes.
   - Run native-compiler heading regressions and real generated-export search 
regressions in every PR build. Extend the three-locale publishing fixture with 
the directive heading.
   
   ## Validation
   
   - `node --test scripts/i18n/__tests__/*.test.cjs`: 85 passed.
   - `node --test scripts/__tests__/build-locales.test.cjs 
scripts/i18n/poc/config.test.cjs`: 12 passed.
   - Confirmed both new regression suites fail with their respective original 
implementations and pass with the fixes.
   - `node scripts/i18n/verify-fixture.cjs`: English, Chinese and Japanese 
production fixture builds passed; strict publishing verification checked 16 
pages with zero skipped checks.
   - Built an additional temporary fixture using the production search plugin, 
SearchBar, SearchPage and utilities. Chromium verified dropdown results, full 
results, reloads, language/version scoping and a 390 px mobile viewport for all 
three locales, with no script or HTTP errors.
   - Checked the actual BI FAQ against its committed `sourceTechnicalHash`; it 
remains unchanged. The new dependency range already resolves to 
`remark-directive` 3.0.1 in `yarn.lock`.
   - `git diff --check`: passed. Full website builds remain covered by PR CI.
   
   ## Review checks
   
   - Goal: both reported failures have reproduced causes and passing regression 
coverage.
   - Scope: changes are limited to the shared heading parser, one search 
import, dependency declaration and validation.
   - Information architecture: document placement and version/locale 
counterparts remain consistent; no content moves are needed.
   - Links/navigation: English heading IDs, page routes, slugs and sidebar 
references remain stable; localized anchors now match the English source.
   - Frontend/workflow conventions: existing components and styling are 
retained; desktop/mobile browser checks passed. CI triggers and permissions are 
unchanged.
   - Verification: native compilation, generated plugin exports, static 
publishing checks and browser behavior cover the affected paths.
   - Other issues: no additional correctness, accessibility, SEO or 
maintainability issues found in this change.
   
   ## Versions
   
   Shared build/runtime fixes apply to all documentation versions.
   
   - [x] dev
   - [x] 4.x
   - [x] 3.x
   - [x] 2.1 or older (not covered by version/language sync gate)
   
   ## Languages
   
   - [x] Chinese
   - [x] English
   - [x] Japanese
   
   ## Docs Checklist
   
   - [x] Checked by AI
   - [x] Test Cases Built
   - [x] Updated required version and language counterparts, or explained why 
not: shared code fixes; no document edits required.
   - [x] If only one language changed, confirmed whether source/translation 
counterparts need sync: not applicable.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to