github-actions[bot] commented on code in PR #68640:
URL: https://github.com/apache/doris/pull/68640#discussion_r4281499233
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/DescribeCommand.java:
##########
@@ -217,7 +217,9 @@ public ShowResultSet doRun(ConnectContext ctx, StmtExecutor
executor) throws Exc
// getBaseSchema, not getFullSchema: a data-shaped sys
table may forward invisible
// columns of the table it is derived from, and DESC
hides those the way it does for
// the table itself (they show up under
show_hidden_columns, like everywhere else).
- List<Column> columns = sysTable.getBaseSchema();
+ // The display view, so DESCRIBE reports the same
nullability for a sys table's
+ // forwarded columns as it does for the table they
came from.
+ List<Column> columns =
sysTable.getBaseSchemaForDisplay();
Review Comment:
[P2] Regenerate the system-table DESC snapshots for declared nullability
This also changes `DESC table$snapshots` and `DESC table$history`, but
`regression-test/data/external_table_p0/iceberg/test_iceberg_sys_table.out`
still expects `Yes` for their required fields (for example `committed_at` and
`snapshot_id` in both `desc_snapshots` blocks). Iceberg 1.11.0 [declares those
snapshot fields
required](https://github.com/apache/iceberg/blob/apache-iceberg-1.11.0/core/src/main/java/org/apache/iceberg/SnapshotsTable.java#L29-L30),
so `parseSchema()` now sets their source nullability to false and this display
path renders `No`. With `enableIcebergTest=true`, the existing system-table
suite therefore fails its recorded assertions. Regenerate the affected
system-table snapshots with the regression runner, alongside the updated
user-table snapshots.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
