github-actions[bot] commented on code in PR #16772:
URL: https://github.com/apache/doris/pull/16772#discussion_r1107974443
##########
be/src/runtime/fragment_mgr.cpp:
##########
@@ -256,9 +260,67 @@ Status FragmentExecState::cancel(const
PPlanFragmentCancelReason& reason, const
return Status::OK();
}
-std::string FragmentExecState::to_http_path(const std::string& file_name) {
+// There can only be one of these callbacks in-flight at any moment, because
+// it is only invoked from the executor's reporting thread.
+// Also, the reported status will always reflect the most recent execution
status,
+// including the final status when execution finishes.
+void FragmentExecState::coordinator_callback(const Status& status,
RuntimeProfile* profile,
+ bool done) {
+ _report_status_cb_impl(
Review Comment:
warning: no matching function for call to object of type
'doris::FragmentExecState::report_status_callback_impl' (aka 'function<void
(const doris::Status &, doris::RuntimeProfile *, bool, doris::TNetworkAddress,
doris::TUniqueId, doris::TUniqueId, int, doris::RuntimeState *,
function<doris::Status (doris::Status)>, function<void (const
doris::PPlanFragmentCancelReason &, const basic_string<char> &)>)>')
[clang-diagnostic-error]
```cpp
_report_status_cb_impl(
^
```
**/usr/include/c++/11/bits/std_function.h:585:** candidate function not
viable: requires 10 arguments, but 11 were provided
```cpp
operator()(_ArgTypes... __args) const
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
