wenzhenghu commented on PR #68727: URL: https://github.com/apache/doris/pull/68727#issuecomment-6162049097
Review follow-up for [the inline review](https://github.com/apache/doris/pull/68727#pullrequestreview-5497879038): all 12 discussions have individual replies and resolution dispositions. The update separates root/nested accounting, limits Audit to three summary keys, defers JSON construction, caches per-pass target names, puts cancellation before reporting, compacts fast-failure logs, registers the Profile key, and removes common-pool/1-second test dependence. The three dynamic settings deliberately retain `volatile` for visibility and their original defaults. Cross-PR landing adaptation and the separate configuration-reference documentation PR remain follow-ups. Running reports require a connection registered with the existing checker; unregistered forwarded/MTMV/stream-load contexts can emit eligible completion/operation events, but do not receive periodic running reports from that checker. Optimizer job identity remains the job class, not an individual rule. Validation of the review-fix code included 105 independent FE tests and two successful Audit regression runs (runner-generated expected output, then verification) with Profile disabled. Those tests preceded the later master merge; I refreshed the merged-head source for these replies and did not rerun the complete tests after that merge. Production overhead and real external-catalog/nested-MV end-to-end coverage remain unmeasured. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
