dataroaring commented on code in PR #16681:
URL: https://github.com/apache/doris/pull/16681#discussion_r1105225767
##########
be/src/olap/cumulative_compaction_policy.cpp:
##########
@@ -219,10 +216,10 @@ void
SizeBasedCumulativeCompactionPolicy::calc_cumulative_compaction_score(
// if current level less then remain level, score contains current
rowset
// and process return; otherwise, score does not contains current
rowset.
if (current_level <= remain_level) {
- return;
+ return score;
}
total_size -= rs_meta->total_disk_size();
- *score -= rs_meta->get_compaction_score();
+ score -= rs_meta->get_compaction_score();
}
}
Review Comment:
return score at the end of the function?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
