github-actions[bot] commented on code in PR #68869:
URL: https://github.com/apache/doris/pull/68869#discussion_r4236822527
##########
docker/thirdparties/run-thirdparties-docker.sh:
##########
@@ -1574,6 +1574,46 @@ validate_kerberos_container() {
fi
}
+# Aux jar for the Paimon fixture in the kerberized metastore: the Paimon
storage
+# handler the metastore loads to derive the fixture table's schema. Same source
+# and same skip-if-present caching the Hive3 stack uses in
prepare-hive-data.sh.
+download_kerberos_paimon_jars() {
+ local auxlib_dir="$1"
+ local
url_prefix="https://${s3BucketName}.${s3Endpoint}/regression/docker/hive3";
+ local jars=(
+ paimon-hive-connector-3.1-1.3-SNAPSHOT.jar
+ )
+ local jar
+
+ for jar in "${jars[@]}"; do
+ if [[ -f "${auxlib_dir}/${jar}" ]]; then
+ echo "Reuse cached kerberos aux jar ${jar}"
+ continue
+ fi
+ echo "Download kerberos aux jar ${jar}"
+ curl -sSfL -o "${auxlib_dir}/${jar}" "${url_prefix}/${jar}"
Review Comment:
[P2] Avoid caching a failed Paimon jar download. If curl is interrupted
after writing part of the jar, it exits nonzero but leaves
`${auxlib_dir}/${jar}`. The next `start_kerberos` run sees `-f` and skips the
download, then Hive loads the truncated jar and fixture creation fails again;
retries cannot recover until someone removes the cached file. Download to a
temporary path and rename it only after curl succeeds, or validate the cached
jar before reuse.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
