github-actions[bot] commented on code in PR #68849:
URL: https://github.com/apache/doris/pull/68849#discussion_r4235999799
##########
fe/fe-core/src/main/java/org/apache/doris/cloud/datasource/CloudInternalCatalog.java:
##########
@@ -1300,6 +1300,11 @@ public void removeSchemaChangeJob(long jobId, long dbId,
long tableId, long inde
}
}
+ @Override
+ public void onCreateTableConflict(long dbId, OlapTable table) throws
DdlException {
+ dropMaterializedIndex(dbId, table.getId(), table.getIndexIdList(true),
true);
Review Comment:
[P2] Clean up the losing table's version key after dropping its indexes.
commit_index writes a table-version key before registration, but this hook only
drops indexes. In legacy mode, an ordinary non-row-format table gets no
partition-version key, so recycle_versions never discovers the loser. In
versioned mode, an auto-partition table with zero initial partitions has no
partition-inverted key for recycle_orphan_partitions. Both paths leave a
permanent MetaService table-version KV after successful index cleanup. Please
reclaim the losing table's version key by its ID and cover both cases in
recycler tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
