AntiTopQuark commented on code in PR #68226:
URL: https://github.com/apache/doris/pull/68226#discussion_r4228779624
##########
fe/fe-core/src/main/java/org/apache/doris/alter/SchemaChangeHandler.java:
##########
@@ -3086,7 +3086,7 @@ public void updatePartitionProperties(Database db, String
tableName, String part
"Partition[" + partitionName + "] does not exist in
table[" + olapTable.getName() + "]");
}
- for (MaterializedIndex index :
partition.getMaterializedIndices(IndexExtState.VISIBLE)) {
+ for (MaterializedIndex index :
partition.getMaterializedIndices(IndexExtState.VISIBLE, true)) {
Review Comment:
done, When shortening the TTL, persist the configuration in the FE edit log
before propagating it to tablets. When extending it, publish the longer
retention window only after all tablets have been updated successfully.
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/BindRelation.java:
##########
@@ -253,12 +253,15 @@ private LogicalPlan makeOlapScan(TableIf table,
UnboundRelation unboundRelation,
List<Long> tabletIds = unboundRelation.getTabletIds();
StreamScanType changeScanType = checkChangeScanCondition((OlapTable)
table, unboundRelation.getScanParams());
if (changeScanType != null) {
+ OlapTable originTable = (OlapTable) table;
+ Pair<Long, Long> timestampRange =
parseTimestampRange(unboundRelation.getScanParams());
+ timestampRange = applyRowBinlogTtl(timestampRange, originTable,
changeScanType,
Review Comment:
done, Reject expired snapshots with an error to avoid returning incomplete
results.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
