dataroaring commented on code in PR #16594:
URL: https://github.com/apache/doris/pull/16594#discussion_r1104691379
##########
be/src/vec/sink/vtablet_sink.cpp:
##########
@@ -688,8 +688,9 @@ Status VNodeChannel::close_wait(RuntimeState* state) {
}
// waiting for finished, it may take a long time, so we couldn't set a
timeout
- while (!_add_batches_finished && !_cancelled) {
- std::this_thread::sleep_for(std::chrono::milliseconds(1));
+ while (!_add_batches_finished && !_cancelled && !state->is_cancelled()) {
+ // std::this_thread::sleep_for(std::chrono::milliseconds(1));
+ bthread_usleep(1000);
Review Comment:
Here, there is another bug, if a fragment is not open, then close_wait does
not handle cancell. bthread_sleep works like sleep in pthread. so I merged it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
