mrhhsg commented on code in PR #68426: URL: https://github.com/apache/doris/pull/68426#discussion_r4217671856
########## be/src/agent/be_exec_version_manager.cpp: ########## @@ -135,9 +152,12 @@ void BeExecVersionManager::check_function_compatibility(int current_be_exec_vers // a. support TIMESTAMP_NS in Thrift descriptors and PBlock exchange. // 15: start from master // a. distinguish Hive OpenCSVSerde row semantics from generic CSV decoding during upgrades. +// 16: start from master +// a. use exact logical frames for map_agg_v2 aggregate state serialization. -const int BeExecVersionManager::max_be_exec_version = SUPPORT_HIVE_OPEN_CSV_VERSION; +const int BeExecVersionManager::max_be_exec_version = SUPPORT_MAP_AGG_V2_EXACT_FRAME_VERSION; const int BeExecVersionManager::min_be_exec_version = 0; Review Comment: Fixed in a89ff82a2857805ebb7bd549cb0c54dad0f5a1f0. Restricted aggregates now carry their original minimum compatible BE execution version (8), rather than comparing against the moving global maximum. The new regression verifies a version-15 stddev_samp direct query and stored AGG_STATE read on version-16 and version-17 BEs; the focused BE unit suite verifies the restriction boundary and stored-state compatibility (8/8 passed). I also merged master and moved map_agg_v2 exact frames to version 17 because master reserved version 16 for Paimon writes. ASAN BE+FE build and all three focused regression suites passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
