jacktengg commented on PR #68399:
URL: https://github.com/apache/doris/pull/68399#issuecomment-6053998954
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#68399
commit: 970744112904a622b237e065aae2e83415f23f8b
base: 310e302bcc975b91265ac589a264d80fb25160e5
reviewed_at: 2026-10-08T14:36+08:00
reviewer: jacktengg
model: gpt-6-astra
effort: xhigh
findings: {blocker: 0, major: 0, minor: 0, nit: 0}
rounds: 1
converged: true
```
**Notes for maintainers**
- `be/src/load/memtable/memtable_writer.cpp:169-195` — Prior F-01 is fixed.
Failed MemTables are discarded under the lock used by pressure flush.
- `be/src/load/memtable/memtable.cpp:589-612` — Prior F-02 is fixed. All
states are constructed before add; a constructor failure destroys only the
completed prefix.
- `be/test/load/memtable/memtable_memory_tracking_test.cpp:536-566` — New
cases cover native string allocation failure and later constructor failure.
Supplied repair logs record an ASAN build and 27 passing MemTable tests; review
itself was read-only. Full clang-tidy did not pass because of existing
diagnostics outside the modified lines.
<sub>Reviewed locally with the `doris-repo-review` pipeline. Repository
policy may accept this receipt for the matching commit; it is not a human
Apache approval.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
