shuke987 opened a new pull request, #68699:
URL: https://github.com/apache/doris/pull/68699
### What problem does this PR solve?
Issue Number: None
Related PR: #68646, #68579
Problem Summary:
Repeated `/review` comments can start overlapping reviews of the same PR.
When one job posts first, the existing duplicate-submission guard rejects the
other job's final candidate, even if it contains different findings. The outer
completion check then replaces that rejection with "No final review submission
was declared".
Serialize the `code-review` job by PR number across comment and dispatch
triggers. Use `cancel-in-progress: false` and `queue: max` so running and
pending review requests are retained. Other PRs and the runtime canary remain
independent. The PR head and review context are resolved after the queued job
starts.
If the duplicate guard still rejects a candidate, save its reason and
complete proposed submission separately from the POST intent, propagate that
reason to the runner, and upload only that JSON as a 14-day artifact. The
candidate remains unsubmitted and cannot prove completion.
This is scoped to the workflow, submission helper and regression tests.
Existing duplicate protection, exclusive POST intent, invocation marker, full
GitHub readback and P0/P1 verdict logic are preserved.
### Release note
None
### Check List (For Author)
- Test:
- [x] Unit Test: 152 tests passed in a local Linux container with network
disabled, covering final submission, resume/process cleanup, workflow auth
handling, status resolution and pass-comment validation.
- [x] Manual test: YAML parsing, Python syntax and `git diff --check`
passed.
- [x] Workflow lint: actionlint 1.7.12 passed with only its unsupported
`concurrency.queue` diagnostic ignored. `queue: max` is verified against the
current [GitHub workflow
syntax](https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#jobsjob_idconcurrency).
No live workflow was dispatched.
- Behavior changed:
- [x] Yes. Reviews of the same PR queue; rejected candidates retain their
specific error and proposed findings.
- Does this need documentation?
- [x] No. Internal CI behavior; the scope and validation limitation are
described here.
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
