This is an automated email from the ASF dual-hosted git repository.
hello-stephen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 21f6c904c66 [improvement](build) Accept GPT-6.1 Sol local review
receipts (#68677)
21f6c904c66 is described below
commit 21f6c904c66b21cd525586ae7e9174607052878c
Author: shuke <[email protected]>
AuthorDate: Wed Sep 30 15:11:32 2026 +0800
[improvement](build) Accept GPT-6.1 Sol local review receipts (#68677)
Related PR: https://github.com/apache/doris-skills/pull/15;
https://github.com/shuke987/codex/pull/4
Problem Summary: A pipeline-equivalent local review performed with
`gpt-6.1-sol` is currently rejected by the PASS receipt validator. Add
its exact model ID with the existing Codex effort gate (`xhigh`, `max`,
or a host-exposed and actually used `ultra`). Preserve all existing
qualified models and receipt checks.
Tests exercise all three accepted efforts, lower/unknown effort
rejection, and rejection of similar unlisted model IDs. The sender
policy is updated in a companion apache/doris-skills PR. Merge this
receiver change before deploying the sender update. This PR does not
change the CI Runner model or install the Codex runtime; rollout of the
fork waits for Codex #4 and live-model acceptance.
---
.github/scripts/test_validate_review_pass_comment.py | 10 ++++++++--
.github/scripts/validate_review_pass_comment.py | 1 +
2 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/.github/scripts/test_validate_review_pass_comment.py
b/.github/scripts/test_validate_review_pass_comment.py
index d0c4a4b84cf..97c0bbbc591 100644
--- a/.github/scripts/test_validate_review_pass_comment.py
+++ b/.github/scripts/test_validate_review_pass_comment.py
@@ -76,6 +76,9 @@ class ValidateReviewPassCommentTest(unittest.TestCase):
("claude-fable-5", "max"),
("claude-fable-5[1m]", "xhigh"),
("claude-fable-5[1m]", "max"),
+ ("gpt-6.1-sol", "xhigh"),
+ ("gpt-6.1-sol", "max"),
+ ("gpt-6.1-sol", "ultra"),
("gpt-6-sol", "xhigh"),
("gpt-6-sol", "max"),
("gpt-6-sol", "ultra"),
@@ -120,6 +123,7 @@ class ValidateReviewPassCommentTest(unittest.TestCase):
"claude-fable-5[1m]",
"claude-fable-5-1",
"claude-fable-5-1[1m]",
+ "gpt-6.1-sol",
"gpt-6-sol",
"gpt-6-astra",
):
@@ -129,8 +133,10 @@ class ValidateReviewPassCommentTest(unittest.TestCase):
validate(make_comment(model=model, effort=effort))
def test_rejects_unlisted_model(self) -> None:
- with self.assertRaisesRegex(ValidationError, "model is not allowed"):
- validate(make_comment(model="gpt-5.6"))
+ for model in ("gpt-5.6", "gpt-6.1", "gpt-6.1-sol-preview",
"gpt-6.1-sol[1m]"):
+ with self.subTest(model=model):
+ with self.assertRaisesRegex(ValidationError, "model is not
allowed"):
+ validate(make_comment(model=model))
def test_rejects_a_different_head(self) -> None:
with self.assertRaisesRegex(ValidationError, "current PR head"):
diff --git a/.github/scripts/validate_review_pass_comment.py
b/.github/scripts/validate_review_pass_comment.py
index 0dffb27f9ff..4dbb8020fc9 100644
--- a/.github/scripts/validate_review_pass_comment.py
+++ b/.github/scripts/validate_review_pass_comment.py
@@ -22,6 +22,7 @@ ALLOWED_EFFORTS_BY_MODEL = {
"claude-fable-5[1m]": frozenset({"xhigh", "max"}),
"claude-fable-5-1": frozenset({"xhigh", "max"}),
"claude-fable-5-1[1m]": frozenset({"xhigh", "max"}),
+ "gpt-6.1-sol": frozenset({"xhigh", "max", "ultra"}),
"gpt-6-sol": frozenset({"xhigh", "max", "ultra"}),
"gpt-6-astra": frozenset({"xhigh", "max", "ultra"}),
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
