yiguolei commented on code in PR #68664:
URL: https://github.com/apache/doris/pull/68664#discussion_r4145197615
##########
be/src/core/data_type/storage_field_type.h:
##########
@@ -17,16 +17,199 @@
#pragma once
+#include "common/exception.h"
#include "core/data_type/define_primitive_type.h"
+#include "storage/field_type.h"
namespace doris {
-enum class FieldType;
+// The FieldType a segment stores a PrimitiveType's values as, and back. Both
+// directions are constexpr, so a template can pick the storage traits of a
+// compute-layer type; at run time an unmapped type throws.
-// Throws Exception when the primitive type has no storage field type mapping.
-[[nodiscard]] FieldType primitive_type_to_storage_field_type(PrimitiveType
type);
+// NOLINTNEXTLINE(readability-function-size): keep the exhaustive mapping
together for auditability.
+constexpr FieldType primitive_type_to_storage_field_type(PrimitiveType type) {
+ switch (type) {
+ case PrimitiveType::INVALID_TYPE:
+ return FieldType::OLAP_FIELD_TYPE_UNKNOWN;
+ case PrimitiveType::TYPE_NULL:
+ return FieldType::OLAP_FIELD_TYPE_NONE;
+ case PrimitiveType::TYPE_BOOLEAN:
+ return FieldType::OLAP_FIELD_TYPE_BOOL;
+ case PrimitiveType::TYPE_TINYINT:
+ return FieldType::OLAP_FIELD_TYPE_TINYINT;
+ case PrimitiveType::TYPE_SMALLINT:
+ return FieldType::OLAP_FIELD_TYPE_SMALLINT;
+ case PrimitiveType::TYPE_INT:
+ return FieldType::OLAP_FIELD_TYPE_INT;
+ case PrimitiveType::TYPE_BIGINT:
+ return FieldType::OLAP_FIELD_TYPE_BIGINT;
+ case PrimitiveType::TYPE_LARGEINT:
+ return FieldType::OLAP_FIELD_TYPE_LARGEINT;
+ case PrimitiveType::TYPE_FLOAT:
+ return FieldType::OLAP_FIELD_TYPE_FLOAT;
+ case PrimitiveType::TYPE_DOUBLE:
+ return FieldType::OLAP_FIELD_TYPE_DOUBLE;
+ case PrimitiveType::TYPE_VARCHAR:
+ return FieldType::OLAP_FIELD_TYPE_VARCHAR;
+ case PrimitiveType::TYPE_DATE:
+ return FieldType::OLAP_FIELD_TYPE_DATE;
+ case PrimitiveType::TYPE_DATETIME:
+ return FieldType::OLAP_FIELD_TYPE_DATETIME;
+ case PrimitiveType::TYPE_CHAR:
+ return FieldType::OLAP_FIELD_TYPE_CHAR;
+ case PrimitiveType::TYPE_STRUCT:
+ return FieldType::OLAP_FIELD_TYPE_STRUCT;
+ case PrimitiveType::TYPE_ARRAY:
+ return FieldType::OLAP_FIELD_TYPE_ARRAY;
+ case PrimitiveType::TYPE_MAP:
+ return FieldType::OLAP_FIELD_TYPE_MAP;
+ case PrimitiveType::TYPE_HLL:
+ return FieldType::OLAP_FIELD_TYPE_HLL;
+ case PrimitiveType::TYPE_DECIMALV2:
+ return FieldType::OLAP_FIELD_TYPE_DECIMAL;
+ case PrimitiveType::TYPE_BITMAP:
+ return FieldType::OLAP_FIELD_TYPE_BITMAP;
+ case PrimitiveType::TYPE_STRING:
+ return FieldType::OLAP_FIELD_TYPE_STRING;
+ case PrimitiveType::TYPE_QUANTILE_STATE:
+ return FieldType::OLAP_FIELD_TYPE_QUANTILE_STATE;
+ case PrimitiveType::TYPE_DATEV2:
+ return FieldType::OLAP_FIELD_TYPE_DATEV2;
+ case PrimitiveType::TYPE_DATETIMEV2:
+ return FieldType::OLAP_FIELD_TYPE_DATETIMEV2;
+ case PrimitiveType::TYPE_TIMESTAMP_NS:
+ return FieldType::OLAP_FIELD_TYPE_TIMESTAMP_NS;
+ case PrimitiveType::TYPE_TIMEV2:
+ return FieldType::OLAP_FIELD_TYPE_TIMEV2;
+ case PrimitiveType::TYPE_DECIMAL32:
+ return FieldType::OLAP_FIELD_TYPE_DECIMAL32;
+ case PrimitiveType::TYPE_DECIMAL64:
+ return FieldType::OLAP_FIELD_TYPE_DECIMAL64;
+ case PrimitiveType::TYPE_DECIMAL128I:
+ return FieldType::OLAP_FIELD_TYPE_DECIMAL128I;
+ case PrimitiveType::TYPE_JSONB:
+ return FieldType::OLAP_FIELD_TYPE_JSONB;
+ case PrimitiveType::TYPE_VARIANT:
+ return FieldType::OLAP_FIELD_TYPE_VARIANT;
+ case PrimitiveType::TYPE_AGG_STATE:
+ return FieldType::OLAP_FIELD_TYPE_AGG_STATE;
+ case PrimitiveType::TYPE_DECIMAL256:
+ return FieldType::OLAP_FIELD_TYPE_DECIMAL256;
+ case PrimitiveType::TYPE_IPV4:
+ return FieldType::OLAP_FIELD_TYPE_IPV4;
+ case PrimitiveType::TYPE_IPV6:
+ return FieldType::OLAP_FIELD_TYPE_IPV6;
+ case PrimitiveType::TYPE_UUID:
+ return FieldType::OLAP_FIELD_TYPE_UUID;
+ case PrimitiveType::TYPE_UINT32:
+ return FieldType::OLAP_FIELD_TYPE_UNSIGNED_INT;
+ case PrimitiveType::TYPE_UINT64:
+ return FieldType::OLAP_FIELD_TYPE_UNSIGNED_BIGINT;
+ case PrimitiveType::TYPE_TIMESTAMPTZ:
+ return FieldType::OLAP_FIELD_TYPE_TIMESTAMPTZ;
+ case PrimitiveType::TYPE_BINARY:
+ case static_cast<PrimitiveType>(14): // TYPE_DECIMAL (deprecated)
+ case static_cast<PrimitiveType>(21): // TYPE_TIME (deprecated)
+ case static_cast<PrimitiveType>(33): // TYPE_LAMBDA_FUNCTION (deprecated)
+ case PrimitiveType::TYPE_FIXED_LENGTH_OBJECT:
+ case PrimitiveType::TYPE_VARBINARY:
+ break;
+ }
-// Throws Exception when the storage field type has no primitive type mapping.
-[[nodiscard]] PrimitiveType storage_field_type_to_primitive_type(FieldType
type);
+ throw Exception(ErrorCode::INTERNAL_ERROR, "Cannot convert PrimitiveType
{} to FieldType",
+ static_cast<int>(type));
+}
+
+// NOLINTNEXTLINE(readability-function-size): keep the exhaustive mapping
together for auditability.
+constexpr PrimitiveType storage_field_type_to_primitive_type(FieldType type) {
Review Comment:
我们有这个转换可能是有问题的，按道理说不能从storage field type 去反向推导出primtive type。
比如 bool 和 int 可能都对应了storage field type的int，此时你没办法从int 推导出上层的计算类型是啥
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
