HappenLee commented on PR #68672: URL: https://github.com/apache/doris/pull/68672#issuecomment-5910026627
/review Please re-review the updated head `6228602b195dc000f25bb371fe2ea5d6661bb1ba` and verify the four prior inline findings are addressed. - Known-NULL TIME casts and array_shuffle/shuffle arguments now reach existing NULL folding; non-NULL calls remain volatile. Unsupported cast pairs still retain their legality checks. - The regression checks zero BE cache lookups for volatile scans at batch sizes 1 and 1024, plus a positive ConditionCacheHit on the second deterministic execution. It isolates global metrics from concurrent suites and internal statistics sessions, restoring the global setting afterward. - Removed the fixed seeded-shuffle count; expected output was generated and independently verified. Validation: FE build/Checkstyle, 93 FE unit tests, and three regression suites passed. The second deterministic scan recorded ConditionCacheHit=1 and ConditionCacheFilteredRows=79872. Build/runtime environment details are documented in the PR description. Please also check the metric isolation and NULL-folding edge cases for any regressions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
