CalvinKirs commented on PR #68660: URL: https://github.com/apache/doris/pull/68660#issuecomment-5908890038
Local skill review completed at head: no Blocker, Major, Minor or Nit finding outstanding. Full report: https://github.com/apache/doris/pull/68660#pullrequestreview-5364665017 One pass in the main session with the repo `code-review` skill, attested below. It read the whole diff at head, tests included, and traced the call chain: `visitGrantTablePrivilege` and `visitRevokeTablePrivilege` are the only callers of `visitMultipartIdentifierOrAsterisk` and the only places in main code that build these commands, `Auth.revokeTablePrivilegeCommand` is called only from `RevokeTablePrivilegeCommand.run` after `validate()` has already dereferenced the pattern, and replay goes through `PrivInfo` without parsing. It raised nothing. An earlier pass by a subagent on the pre-rebase head also raised nothing; it is not part of this attestation. Local build, FE UT and the new `account_p0` regression suite ran on this head's tree. <!-- doris-repo-review:v1:begin --> ```yaml schema: doris-repo-review/v1 status: PASS pr: apache/doris#68660 commit: 363206cfc1f24665c839ba7e33c27a94a1a4eae7 base: 0a3595e61870ed302eb8b732f968e48823bc0cc4 reviewed_at: 2026-09-30T17:59:48+08:00 reviewer: CalvinKirs model: claude-fable-5-1 effort: xhigh findings: {blocker: 0, major: 0, minor: 0, nit: 0} rounds: 1 converged: true ``` <!-- doris-repo-review:v1:end --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
