github-actions[bot] commented on code in PR #68622: URL: https://github.com/apache/doris/pull/68622#discussion_r4142246387
########## cloud/test/recycler_benchmark_test.cpp: ########## @@ -112,7 +110,7 @@ void set_obj_store_provider(const std::string& provider, ObjectStoreInfoPB* obj_ } // Number of recyclable rowsets seeded per branch. Review Comment: [P1] Isolate this benchmark from default Cloud test runs. This source is still compiled into `recycler_test` (`cloud/test/CMakeLists.txt:42-50`), and `cloud/script/run_all_tests.sh` runs that binary by default, so `RecyclerBenchmarkTest.RecycleRowsets` still adds the full benchmark to routine tests. There is also no `recycler_benchmark_test` target, so `--test recycler_benchmark_test` exits successfully without running it. Please move this test into its own target and gate that target in the default runner while keeping explicit selection working. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
