This is an automated email from the ASF dual-hosted git repository. shuke987 pushed a commit to branch codex/allow-gpt-6-1-sol-review in repository https://gitbox.apache.org/repos/asf/doris-skills.git
commit 3f1bff3c82392971e3a8ebe88498c41310958227 Author: shuke <[email protected]> AuthorDate: Wed Sep 30 14:54:09 2026 +0800 Allow GPT-6.1 Sol for qualified local reviews --- skills/doris-repo-review/references/qualified-runtime.md | 7 ++++--- skills/doris-repo-review/scripts/review-runtime-policy.sh | 4 ++-- verify/repo-review/post-comment.sh | 2 +- verify/repo-review/runtime-attestation.sh | 12 ++++++------ verify/repo-review/runtime-policy.sh | 12 ++++++------ 5 files changed, 19 insertions(+), 18 deletions(-) diff --git a/skills/doris-repo-review/references/qualified-runtime.md b/skills/doris-repo-review/references/qualified-runtime.md index 391d323..c69bb92 100644 --- a/skills/doris-repo-review/references/qualified-runtime.md +++ b/skills/doris-repo-review/references/qualified-runtime.md @@ -4,7 +4,7 @@ Establish the reviewer runtime before reading source. A pipeline-equivalent revi | Host | Models | Effort | |---|---|---| -| Codex | `gpt-6-astra`, `gpt-6-sol` | `xhigh`, `max`, or `ultra` | +| Codex | `gpt-6-astra`, `gpt-6.1-sol`, `gpt-6-sol` | `xhigh`, `max`, or `ultra` | | Claude Code | `claude-fable-5-1`, `claude-fable-5-1[1m]`, `claude-opus-5-5`, `claude-opus-5-5[1m]`, `claude-fable-5`, or `claude-fable-5[1m]` | `xhigh` or `max` | Prefer `gpt-6-astra` on Codex and Fable 5.1 on Claude Code, with `xhigh` as the default @@ -15,7 +15,8 @@ when the preferred model is unavailable. The same policy applies to the lead and every substantive coverage reviewer. `ultra` is accepted only when the Codex host explicitly exposes and actually uses that setting. -The GPT-6 Sol API supports effort only through `max`; do not relabel an API `max` run as `ultra`. +The GPT-6.1 Sol and GPT-6 Sol APIs support effort only through `max`; do not relabel an API +`max` run as `ultra`. Validate the exact values with: @@ -38,7 +39,7 @@ When the current task cannot be retained under the rules above, spawn one lead r - `model: "gpt-6-astra"` - `reasoning_effort: "xhigh"` -If Astra is unavailable, fall back to `gpt-6-sol` with `xhigh`. If the user explicitly requests +If Astra is unavailable, fall back to `gpt-6.1-sol` with `xhigh`. If the user explicitly requests another qualified runtime, use its exact model and supported effort instead. Preserve a current preferred runtime's qualified effort rather than resetting it to `xhigh`. diff --git a/skills/doris-repo-review/scripts/review-runtime-policy.sh b/skills/doris-repo-review/scripts/review-runtime-policy.sh index 0b1ed08..c5aff9e 100755 --- a/skills/doris-repo-review/scripts/review-runtime-policy.sh +++ b/skills/doris-repo-review/scripts/review-runtime-policy.sh @@ -3,7 +3,7 @@ is_eligible_review_model() { case "$1" in - claude-opus-5-5|claude-opus-5-5\[1m\]|claude-fable-5|claude-fable-5\[1m\]|claude-fable-5-1|claude-fable-5-1\[1m\]|gpt-6-sol|gpt-6-astra) return 0 ;; + claude-opus-5-5|claude-opus-5-5\[1m\]|claude-fable-5|claude-fable-5\[1m\]|claude-fable-5-1|claude-fable-5-1\[1m\]|gpt-6.1-sol|gpt-6-sol|gpt-6-astra) return 0 ;; *) return 1 ;; esac } @@ -18,7 +18,7 @@ is_eligible_review_effort() { *) return 1 ;; esac ;; - gpt-6-sol|gpt-6-astra) + gpt-6.1-sol|gpt-6-sol|gpt-6-astra) case "$effort" in xhigh|max|ultra) return 0 ;; *) return 1 ;; diff --git a/verify/repo-review/post-comment.sh b/verify/repo-review/post-comment.sh index e643630..eda6a9d 100755 --- a/verify/repo-review/post-comment.sh +++ b/verify/repo-review/post-comment.sh @@ -131,7 +131,7 @@ grep -Fq "findings: {blocker: 0, major: 0, minor: 1, nit: 0}" "$CTX/pr-comment.m [ -z "${RECEIPT_OUTPUT:-}" ] || cp "$CTX/pr-comment.md" "$RECEIPT_OUTPUT" pass "verified dry run renders a pipeline-compatible receipt" -for model in gpt-6-sol claude-opus-5-5 'claude-opus-5-5[1m]'; do +for model in gpt-6.1-sol gpt-6-sol claude-opus-5-5 'claude-opus-5-5[1m]'; do "$S/record-review-runtime.sh" --ctx "$CTX" --model "$model" --effort xhigh >/dev/null "$S/post-pass-comment.sh" --ctx "$CTX" --dry-run > "$TMP_ROOT/dry-run" grep -Fxq "model: $model" "$CTX/pr-comment.md" || fail "new model receipt is wrong: $model" diff --git a/verify/repo-review/runtime-attestation.sh b/verify/repo-review/runtime-attestation.sh index f56045b..5ae0af6 100755 --- a/verify/repo-review/runtime-attestation.sh +++ b/verify/repo-review/runtime-attestation.sh @@ -28,14 +28,14 @@ write_meta() { CTX="$TMP_ROOT/ctx" write_meta "$CTX" "$HEAD_SHA" -"$RECORDER" --ctx "$CTX" --model gpt-6-sol --effort xhigh >/dev/null +"$RECORDER" --ctx "$CTX" --model gpt-6.1-sol --effort xhigh >/dev/null jq -e --arg head "$HEAD_SHA" \ - '.model == "gpt-6-sol" and .effort == "xhigh" and .commit == $head' \ + '.model == "gpt-6.1-sol" and .effort == "xhigh" and .commit == $head' \ "$CTX/review-runtime.json" >/dev/null || fail "runtime JSON fields are wrong" pass "qualified runtime records model, effort, and commit" -expect_failure "low effort is rejected" "not eligible for model 'gpt-6-sol'" \ - "$RECORDER" --ctx "$CTX" --model gpt-6-sol --effort high +expect_failure "low effort is rejected" "not eligible for model 'gpt-6.1-sol'" \ + "$RECORDER" --ctx "$CTX" --model gpt-6.1-sol --effort high [ ! -e "$CTX/review-runtime.json" ] || fail "failed replacement left an old runtime record" pass "failed replacement removes the old attestation" @@ -52,7 +52,7 @@ expect_failure "unlisted model is rejected" "is not eligible" \ "$RECORDER" --ctx "$CTX" --model gpt-5.6-terra --effort xhigh for model in gpt-5.6-sol claude-opus-5 'claude-opus-5[1m]'; do - "$RECORDER" --ctx "$CTX" --model gpt-6-sol --effort xhigh >/dev/null + "$RECORDER" --ctx "$CTX" --model gpt-6.1-sol --effort xhigh >/dev/null expect_failure "retired model is rejected: $model" "is not eligible" \ "$RECORDER" --ctx "$CTX" --model "$model" --effort xhigh [ ! -e "$CTX/review-runtime.json" ] || fail "retired replacement left an old runtime record" @@ -61,6 +61,6 @@ done BAD_CTX="$TMP_ROOT/bad-ctx" write_meta "$BAD_CTX" deadbeef expect_failure "short commit is rejected" "not a full SHA" \ - "$RECORDER" --ctx "$BAD_CTX" --model gpt-6-sol --effort xhigh + "$RECORDER" --ctx "$BAD_CTX" --model gpt-6.1-sol --effort xhigh echo "$PASS_COUNT runtime-attestation tests passed" diff --git a/verify/repo-review/runtime-policy.sh b/verify/repo-review/runtime-policy.sh index 423e124..8e8599c 100755 --- a/verify/repo-review/runtime-policy.sh +++ b/verify/repo-review/runtime-policy.sh @@ -18,12 +18,12 @@ fail() { # shellcheck source=/dev/null . "$POLICY" -for model in claude-opus-5-5 'claude-opus-5-5[1m]' claude-fable-5 'claude-fable-5[1m]' claude-fable-5-1 'claude-fable-5-1[1m]' gpt-6-sol gpt-6-astra; do +for model in claude-opus-5-5 'claude-opus-5-5[1m]' claude-fable-5 'claude-fable-5[1m]' claude-fable-5-1 'claude-fable-5-1[1m]' gpt-6.1-sol gpt-6-sol gpt-6-astra; do is_eligible_review_model "$model" || fail "eligible model rejected: $model" done pass "exact model allowlist is accepted" -for model in claude-opus-4-8 'claude-opus-4-8[1m]' claude-opus-5.1 claude-fable-4 gpt-5.6 gpt-5.6-terra gpt-5.6-luna gpt-5.7-sol gpt-6 unknown; do +for model in claude-opus-4-8 'claude-opus-4-8[1m]' claude-opus-5.1 claude-fable-4 gpt-5.6 gpt-5.6-terra gpt-5.6-luna gpt-5.7-sol gpt-6.1 gpt-6.1-sol-preview gpt-6.1-sol[1m] gpt-6 unknown; do if is_eligible_review_model "$model"; then fail "unlisted model accepted: $model" fi @@ -60,7 +60,7 @@ for model in claude-opus-5-5 'claude-opus-5-5[1m]' claude-fable-5 'claude-fable- done pass "Claude models reject unsupported ultra effort" -for model in gpt-6-sol gpt-6-astra; do +for model in gpt-6.1-sol gpt-6-sol gpt-6-astra; do for effort in xhigh max ultra; do is_eligible_review_effort "$model" "$effort" \ || fail "eligible Codex runtime rejected: $model ($effort)" @@ -68,7 +68,7 @@ for model in gpt-6-sol gpt-6-astra; do done pass "Codex accepts xhigh, max, and ultra" -for model in claude-opus-5-5 'claude-opus-5-5[1m]' claude-fable-5 'claude-fable-5[1m]' claude-fable-5-1 'claude-fable-5-1[1m]' gpt-6-sol gpt-6-astra; do +for model in claude-opus-5-5 'claude-opus-5-5[1m]' claude-fable-5 'claude-fable-5[1m]' claude-fable-5-1 'claude-fable-5-1[1m]' gpt-6.1-sol gpt-6-sol gpt-6-astra; do for effort in none minimal low medium high unknown ''; do if is_eligible_review_effort "$model" "$effort"; then fail "ineligible runtime accepted: $model ($effort)" @@ -77,8 +77,8 @@ for model in claude-opus-5-5 'claude-opus-5-5[1m]' claude-fable-5 'claude-fable- done pass "lower and unknown efforts are rejected for every host" -"$POLICY" check gpt-6-sol xhigh >/dev/null -if "$POLICY" check gpt-6-sol high >/dev/null 2>&1; then +"$POLICY" check gpt-6.1-sol xhigh >/dev/null +if "$POLICY" check gpt-6.1-sol high >/dev/null 2>&1; then fail "policy CLI accepted high effort" fi if "$POLICY" check claude-opus-5-5 ultra >/dev/null 2>&1; then --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
