TsukiokaKogane commented on code in PR #68514:
URL: https://github.com/apache/doris/pull/68514#discussion_r4140453805
##########
fe/fe-core/src/main/java/org/apache/doris/cloud/transaction/CloudGlobalTransactionMgr.java:
##########
@@ -871,7 +871,19 @@ private TransactionState
commitTxn(CommitTxnRequest.Builder builder, List<Table>
// when ready to send, while retaining the existing table locks and
callback cleanup scope.
Database database =
Env.getCurrentInternalCatalog().getDbOrMetaException(builder.getDbId());
Set<Long> commitTsoTableIds =
tableList.stream().map(Table::getId).collect(Collectors.toSet());
- long commitTso = TransactionUtil.getCommitTSO(transactionId, database,
commitTsoTableIds);
+ long commitTso;
+ try {
+ commitTso = TransactionUtil.getCommitTSO(transactionId, database,
commitTsoTableIds);
+ } catch (TransactionCommitFailedException e) {
+ // A previous commit may have succeeded before its response was
lost. Recover its TSO
+ // and let the existing commit RPC handle idempotency, lazy
publish and 2PC status checks.
+ TransactionState persisted =
getTransactionState(builder.getDbId(), transactionId);
Review Comment:
existing problem not relate to incomming changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
