u70b3 commented on code in PR #67978:
URL: https://github.com/apache/doris/pull/67978#discussion_r4139924916
##########
regression-test/suites/external_table_p0/lance/test_lance_index_admission.groovy:
##########
@@ -64,13 +65,28 @@ suite("test_lance_index_admission",
"p0,external,nonConcurrent") {
assertEquals(1, quotaRows.size())
String originalGate = gateRows[0][1].toString()
String originalQuota = quotaRows[0][1].toString()
+ def dispatchIntervalRows = master_sql """ADMIN SHOW FRONTEND CONFIG LIKE
'lance_index_job_dispatch_interval_second'"""
+ assertEquals(1, dispatchIntervalRows.size())
+ String originalDispatchInterval = dispatchIntervalRows[0][1].toString()
+ // The interval pin below outlives the daemon's in-flight wait on this
shipped
+ // default, so the wait is sized correctly.
+ assertEquals("10", originalDispatchInterval)
// The main scenario admits two jobs on one table, independently of the
// cluster's original quota. The dedicated quota case temporarily lowers
it.
String suiteQuota = Math.max(2L, originalQuota.toLong()).toString()
Throwable suiteFailure = null
try {
master_sql """ADMIN SET FRONTEND CONFIG
("lance_index_job_max_unresolved_per_table" = "${suiteQuota}")"""
+ // Pin the dispatcher's polling interval to one hour so no dispatch
round can
+ // fire between admission and the PENDING assertions below: this
slice's
+ // backends answer submit_lance_index_job with a clean not-implemented
error,
+ // which converges a dispatched job to NOT_COMMITTED and would break
this
+ // suite's PENDING premise. A cycle already sleeping on the shipped
interval
Review Comment:
done, both suites replaced the interval pin with the hard pause barrier
lance_index_job_dispatcher_paused set before admission (0c97204180).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
