github-actions[bot] commented on code in PR #68595:
URL: https://github.com/apache/doris/pull/68595#discussion_r4130461289
##########
env.sh:
##########
@@ -69,7 +69,12 @@ CELLARS=(
wget
pcre
maven
- llvm@20
+ # 22.1.8 is the first compiler-rt whose ASAN runtime survives macOS 26.4+:
+ # dyld reimplemented dyld_shared_cache_iterate_text in Swift there and its
+ # _Block_copy allocation re-enters ASAN init, so every -fsanitize=address
+ # binary built with llvm@20 deadlocks before main()
(llvm/llvm-project#182943,
+ # fixed in 22.1.8; no 20.x or 21.x backport exists).
+ llvm@22
Review Comment:
[P1] Keep fresh macOS third-party builds compatible with LLVM 22
With no `thirdparty/installed/lib/libbrotlienc.a`, `./build.sh --be` runs
the default third-party build, which inherits the new LLVM 22 `CC`/`CXX` and
compiles unixODBC 2.3.7. Its `SQLBrowseConnectW.c:424` passes `SQLSMALLINT*` to
an `int*` parameter; Clang 22 makes `-Wincompatible-pointer-types` an error.
The LLVM 20 override exists only in the two artifact jobs, so it does not fix
this fresh source-build path. Patch or scope the unixODBC compilation, or
select LLVM 20 for third-party builds before switching BE to LLVM 22.
##########
be/CMakeLists.txt:
##########
@@ -467,7 +467,16 @@ if (COMPILER_CLANG)
# clang's -Wpass-failed turns that missed *hint* into
an
# -Werror failure. The diagnostic carries no
correctness
# signal, so drop it.
- -Wno-pass-failed)
+ -Wno-pass-failed
+ # clang 22 reports __COUNTER__ under -Wpedantic as a
C2y
+ # extension (-Wc2y-extensions). runtime_profile.h
expands it to
+ # give two SCOPED_TIMER / SCOPED_RAW_TIMER uses on the
same
+ # line distinct names -- a long-standing clang/gcc/MSVC
+ # extension that only reached the standard in C23, and
the
+ # diagnostic carries no correctness signal. clang 20
accepts
+ # the -Wno- for an unknown warning option silently, so
this
+ # needs no version guard.
+ -Wno-c2y-extensions)
Review Comment:
[P1] Guard this flag for supported older Clang versions
This CMake file accepts Clang 16+, but Clang 16–18 do not define the
`c2y-extensions` warning group. They report the unknown `-Wno-c2y-extensions`
option, and the existing `-Werror` makes that diagnostic fatal for BE targets.
Add the flag only for a Clang version that recognizes it (or just Clang 22,
where the suppression is needed) so Clang 16–18 builds continue to work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
