github-actions[bot] commented on code in PR #68594:
URL: https://github.com/apache/doris/pull/68594#discussion_r4133911784
##########
cloud/src/recycler/recycler.cpp:
##########
@@ -4653,7 +4653,7 @@ int InstanceRecycler::delete_rowset_data(
continue;
}
}
- if (rs.rowset_state() == RowsetStatePB::BEGIN_PARTIAL_UPDATE) {
+ if (rs.rowset_state() == RowsetStatePB::BEGIN_PARTIAL_UPDATE &&
!is_formal_rowset) {
Review Comment:
[P2] Reclaim unrecorded segments before retiring formal partial-update
rowsets. A publish can write a transient segment and fail before
`update_tmp_rowset`; `save_delete_bitmap` has already cached the current rowset
IDs, so a same-BE retry can write zero new rows and skip that metadata update.
The resulting formal `BEGIN_PARTIAL_UPDATE` metadata still lists only the
original segments. This branch now deletes those listed files and then removes
the COMPACT/DROP recycle key, leaving the transient object without rowset-level
cleanup while the tablet remains. Keep a safe cleanup path for unrecorded
segments before removing the key, and cover this retry sequence in a recycler
test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
