Gabriel39 commented on PR #66227: URL: https://github.com/apache/doris/pull/66227#issuecomment-5889012317
Fixed the latest review findings: - Historical TIMESTAMP/TIMESTAMP_LTZ evolution from precision <= 6 to precision 7-9 now falls back to JNI. This prevents valid dates such as years 1600 and 2300 from becoming NULL when Arrow converts them to nanoseconds. Coverage includes nested rows, arrays and map keys/values, persisted Parquet inputs, NULLs and safe widening controls. - Profile storage freezes its terminal completion state before serialization, so concurrent rendering cannot replace INCOMPLETE with COLLECTING before the storage path is published. A failed write releases the frozen state. Deterministic interleaving and failed-write/retry tests cover both paths. Validation completed locally before pushing: 148 focused FE tests, 21 existing profile/persistence tests, FE Checkstyle, eight live timestamp evolution/control fixtures, and both complete Paimon regression suites. The live comparison reproduced the pre-fix NULL results and verified correct values and JNI fallback after the fix; safe precision-6 controls still use Rust. Live tests used the existing CI BE artifact with freshly compiled modified FE classes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
