Gabriel39 commented on code in PR #68596: URL: https://github.com/apache/doris/pull/68596#discussion_r4129743672
########## regression-test/suites/arrow_flight_sql_p0/test_flight_utf8_validation.groovy: ########## @@ -0,0 +1,76 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +suite("test_flight_utf8_validation", "arrow_flight_sql") { + sql "DROP TABLE IF EXISTS flight_utf8_input" + sql """CREATE TABLE flight_utf8_input (id INT, encoded STRING) + DUPLICATE KEY(id) DISTRIBUTED BY HASH(id) BUCKETS 1 + PROPERTIES ("replication_num" = "1")""" + sql """INSERT INTO flight_utf8_input VALUES + (1, '616263'), (2, 'E4B8ADF09F9880'), (3, ''), (4, NULL), + (5, '84'), (6, 'C0AF'), (7, 'EDA080'), (8, 'F4908080'), + (9, 'C2'), (10, 'A2')""" + + // TestAction uses the current JDBC connection, so explicitly bind it to Flight. + def flightUrl = context.getArrowFlightSqlConnection().getMetaData().getURL() + connect(context.config.jdbcUser, context.config.jdbcPassword, flightUrl) { Review Comment: Fixed in 6dc25ed735. The regression now reuses context.getArrowFlightSqlConnection() and arrow_flight_sql throughout, preserving the configured Flight credentials and avoiding the TLS-dependent early return in connect(). The P0 constant-input check also disables constant folding and scans a table so invalid bytes reach BE Flight validation. Direct result assertions fix the Cloud P0 Groovy getAt() failure. Six mock JDBC script checks and six focused ASAN Flight tests passed; live regression verification is pending the new CI run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
