github-actions[bot] commented on code in PR #67228: URL: https://github.com/apache/doris/pull/67228#discussion_r4129073418
########## be/src/common/config.cpp: ########## @@ -1507,6 +1507,17 @@ DEFINE_mInt64(auto_inc_low_water_level_mark_size_ratio, "3"); DEFINE_mInt64(auto_inc_fetch_thread_num, "3"); // default max to 2048 connections DEFINE_mInt64(lookup_connection_cache_capacity, "2048"); +// Number of reusable result blocks retained by each point lookup cache entry. +DEFINE_mInt32(lookup_connection_cache_block_pool_size, "1"); Review Comment: [P1] Validate the range of this mutable pool size before accepting it. `set_config` accepts `0` or a negative value and reports it (and persists it when requested), while the callback silently runs with `1`. It also accepts `INT32_MAX`, which `Reusable::init` passes to `_block_pool.resize` and then eagerly fills with Blocks on the next new cached context. The pointer vector alone is about 16 GiB on a 64-bit BE, and allocation exceptions escape the point-query worker. Reject values outside a documented safe range, or separate the retention limit from eager preallocation; cover both boundaries in a config test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
