airborne12 opened a new pull request, #68607:
URL: https://github.com/apache/doris/pull/68607
### What problem does this PR solve?
Related PR: #67537, #68584
Problem Summary:
The SNII golden corpus test on master skipped unless `SNII_GOLDEN_DIR` was
supplied. This left the existing wire format compatibility checks out of
ordinary BE test runs. Several SNII comments also retained design task labels,
long implementation histories, or release-specific wording.
This PR bundles a small synthetic compatibility corpus under a neutral path
and verifies it by default. An explicit `SNII_GOLDEN_DIR` still overrides the
corpus, and write mode requires an explicit output directory. It also
simplifies SNII comments and removes release-specific descriptions. The proto
schema and field numbers are unchanged relative to the current master branch;
no production logic or array regression data changes.
### Release note
None
### Check List (For Author)
- Test
- [ ] Regression test
- [x] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason
Golden corpus readback: 513 checks, 0 mismatches, using a recent BE test
binary that includes #67537. A fresh BE build from this exact head has not been
run. The complete merged-tree clang-format and FE Checkstyle preflight passed
for head `e9ff8a5bf3c` against master `1fc02707cb1c`. The complete PR diff
passed the English description check with no exceptions. The proto's noncomment
schema matches current master exactly.
- Behavior changed:
- [x] No. Production behavior is unchanged; the existing compatibility
test now runs by default.
- [ ] Yes.
- Does this need documentation?
- [x] No.
- [ ] Yes.
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]