xy720 opened a new pull request, #68558:
URL: https://github.com/apache/doris/pull/68558
### What problem does this PR solve?
Related PR: #68541
Follow-up to the review on #68541.
The catalog recycle bin has never preserved a partition's storage policy.
Catalog recycle bin does not store it, and do not restore it (they only
handle data property, replica allocation, in-memory, mutable and inverted-index
format).
So after a soft `DROP PARTITION`(without force) followed by `RECOVER`, the
partition loses its storage policy.
This PR threads the storage policy through the recycle bin.
- `RecyclePartitionInfo` persists the storage policy (new `sp` field).
- `recoverPartition()` and `replayRecoverPartition()` restore it.
- `replacePartition()` (INSERT OVERWRITE) also carries the storage policy
over to the new partition and into the recycle bin.
Old images without the new field deserialize it as null, so recover keeps
its previous behavior for them; no compatibility break.
### Release note
Fix a bug where a partition's storage policy was lost after DROP PARTITION
and
RECOVER.
### Check List (For Author)
- Test
- [ ] Regression test
- [x] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- Behavior changed:
- [x] No.
- [ ] Yes.
- Does this need documentation?
- [x] No.
- [ ] Yes.
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
