github-actions[bot] commented on code in PR #68478:
URL: https://github.com/apache/doris/pull/68478#discussion_r4090966568
##########
be/src/exprs/aggregate/aggregate_function_linear_histogram.cpp:
##########
@@ -34,9 +34,10 @@ AggregateFunctionPtr
create_aggregate_function_linear_histogram(const std::strin
const
DataTypePtr& result_type,
const bool
result_is_nullable,
const
AggregateFunctionAttr& attr) {
- using creator = creator_with_type_list<TYPE_TINYINT, TYPE_SMALLINT,
TYPE_INT, TYPE_BIGINT,
- TYPE_LARGEINT, TYPE_FLOAT,
TYPE_DOUBLE, TYPE_DECIMAL32,
- TYPE_DECIMAL64, TYPE_DECIMAL128I,
TYPE_DECIMAL256>;
+ using creator =
+ creator_with_type_list<TYPE_BOOLEAN, TYPE_TINYINT, TYPE_SMALLINT,
TYPE_INT, TYPE_BIGINT,
+ TYPE_LARGEINT, TYPE_FLOAT, TYPE_DOUBLE,
TYPE_DECIMAL32,
+ TYPE_DECIMAL64, TYPE_DECIMAL128I,
TYPE_DECIMAL256>;
Review Comment:
[P2] Restore the other type dropped by the refactor
The pre-#54509 switch supported `TYPE_DECIMALV2` as well as BOOLEAN, and
that refactor removed both dispatch arms plus the DecimalV2 unit invocations.
This edited list restores only BOOLEAN. DecimalV2 is still reachable when
`enable_decimal_conversion=false`; `LinearHistogram` preserves that primitive
through its unindexed `AnyDataType`, so this creator still returns null and BE
reports `Agg Function ... is not implemented`. Please restore DecimalV2 here
too and reinstate its coverage. The repair also needs to account for
DecimalV2's distinct value representation and fixed execution scale; adding
only the enum is not compatible with the current generic DecimalV3 `.value`
branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
