github-actions[bot] commented on code in PR #16562: URL: https://github.com/apache/doris/pull/16562#discussion_r1101192840
########## be/test/vec/core/column_complex_test.cpp: ########## @@ -83,7 +84,42 @@ class ColumnBitmapTest : public testing::Test { DataTypeBitMap _bitmap_type; }; -TEST_F(ColumnBitmapTest, SerializeAndDeserialize) { +class ColumnQuantileStateTest : public testing::Test { +public: + void SetUp() override {} Review Comment: warning: 'virtual' is redundant since the function is already declared 'override' [modernize-use-override] ```suggestion void SetUp() override {} ``` ########## be/test/vec/core/column_complex_test.cpp: ########## @@ -83,7 +84,42 @@ DataTypeBitMap _bitmap_type; }; -TEST_F(ColumnBitmapTest, SerializeAndDeserialize) { +class ColumnQuantileStateTest : public testing::Test { +public: + void SetUp() override {} + void TearDown() override {} Review Comment: warning: 'virtual' is redundant since the function is already declared 'override' [modernize-use-override] ```suggestion void TearDown() override {} ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org