github-actions[bot] commented on PR #16528:
URL: https://github.com/apache/doris/pull/16528#issuecomment-1423685306
#### `sh-checker report`
To get the full details, please check in the
[job]("https://github.com/apache/doris/actions/runs/4131488941";) output.
<details>
<summary>shellcheck errors</summary>
```
'shellcheck ' returned error 1 finding the following syntactical issues:
----------
In docker/runtime/be/resource/entry_point.sh line 33:
if [ "$#" -eq 0 ]; then text="$(cat)"; fi
^------------^ SC2292 (style): Prefer [[ ]] over [ ] for tests in
Bash/Ksh.
Did you mean:
if [[ "$#" -eq 0 ]]; then text="$(cat)"; fi
In docker/runtime/be/resource/entry_point.sh line 34:
local dt="$(date -Iseconds)"
^-- SC2155 (warning): Declare and assign separately to avoid
masking return values.
In docker/runtime/be/resource/entry_point.sh line 35:
printf '%s [%s] [Entrypoint]: %s\n' "$dt" "$type" "$text"
^-^ SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
^---^ SC2250 (style): Prefer
putting braces around variable references even when not strictly required.
^---^ SC2250 (style):
Prefer putting braces around variable references even when not strictly
required.
Did you mean:
printf '%s [%s] [Entrypoint]: %s\n' "${dt}" "${type}" "${text}"
In docker/runtime/be/resource/entry_point.sh line 50:
[ "${#FUNCNAME[@]}" -ge 2 ] &&
^-------------------------^ SC2292 (style): Prefer [[ ]] over [ ] for
tests in Bash/Ksh.
Did you mean:
[[ "${#FUNCNAME[@]}" -ge 2 ]] &&
In docker/runtime/be/resource/entry_point.sh line 51:
[ "${FUNCNAME[0]}" = '_is_sourced' ] &&
^-- SC2292 (style): Prefer [[ ]] over [ ] for tests in Bash/Ksh.
Did you mean:
[[ "${FUNCNAME[0]}" = '_is_sourced' ]] &&
In docker/runtime/be/resource/entry_point.sh line 52:
[ "${FUNCNAME[1]}" = 'source' ]
^-----------------------------^ SC2292 (style): Prefer [[ ]] over [
] for tests in Bash/Ksh.
Did you mean:
[[ "${FUNCNAME[1]}" = 'source' ]]
In docker/runtime/be/resource/entry_point.sh line 57:
if [ -d "${DORIS_HOME}/be/storage/data" ]; then
^-- SC2292 (style): Prefer [[ ]] over [ ] for tests in Bash/Ksh.
^-----------^ SC2154 (warning): DORIS_HOME is referenced but
not assigned.
Did you mean:
if [[ -d "${DORIS_HOME}/be/storage/data" ]]; then
In docker/runtime/be/resource/entry_point.sh line 63:
local feServerArray=($(echo "${FE_SERVERS}" | awk '{gsub (/,/," ");
print $0}'))
^-- SC2207 (warning): Prefer mapfile or read -a to
split command output (or quote to avoid splitting).
In docker/runtime/be/resource/entry_point.sh line 69:
feIpArray[$tmpFeId]=${tmpFeIp}
^------^ SC2250 (style): Prefer putting braces around
variable references even when not strictly required.
Did you mean:
feIpArray[${tmpFeId}]=${tmpFeIp}
In docker/runtime/be/resource/entry_point.sh line 75:
BE_HOST_IP=$(echo "${BE_ADDR}" | awk -F ':' '{ sub(/ /, ""); print$1}')
^--------^ SC2154 (warning): BE_ADDR is referenced
but not assigned.
In docker/runtime/be/resource/entry_point.sh line 86:
mysql -uroot -P9030 -h${MASTER_FE_IP} --comments "$@" 2>/dev/null
^-------------^ SC2086 (info): Double quote to
prevent globbing and word splitting.
Did you mean:
mysql -uroot -P9030 -h"${MASTER_FE_IP}" --comments "$@" 2>/dev/null
In docker/runtime/be/resource/entry_point.sh line 93:
if [[ $(($i % 20)) == 1 ]]; then
^-- SC2004 (style): $/${} is unnecessary on arithmetic
variables.
^-- SC2250 (style): Prefer putting braces around variable
references even when not strictly required.
Did you mean:
if [[ $((${i} % 20)) == 1 ]]; then
In docker/runtime/be/resource/entry_point.sh line 103:
if [[ $(($i % 20)) == 1 ]]; then
^-- SC2004 (style): $/${} is unnecessary on arithmetic
variables.
^-- SC2250 (style): Prefer putting braces around
variable references even when not strictly required.
Did you mean:
if [[ $((${i} % 20)) == 1 ]]; then
In docker/runtime/be/resource/entry_point.sh line 109:
if ! [[ $is_fe_start ]]; then
^----------^ SC2244 (style): Prefer explicit -n to check
non-empty string (or use =/-ne to check boolean/integer).
^----------^ SC2250 (style): Prefer putting braces around
variable references even when not strictly required.
Did you mean:
if ! [[ -n $is_fe_start ]]; then
In docker/runtime/be/resource/entry_point.sh line 120:
case "$f" in
^-- SC2250 (style): Prefer putting braces around variable
references even when not strictly required.
Did you mean:
case "${f}" in
In docker/runtime/be/resource/entry_point.sh line 122:
if [ -x "$f" ]; then
^---------^ SC2292 (style): Prefer [[ ]] over [ ] for tests
in Bash/Ksh.
^-- SC2250 (style): Prefer putting braces around
variable references even when not strictly required.
Did you mean:
if [[ -x "${f}" ]]; then
In docker/runtime/be/resource/entry_point.sh line 123:
doris_note "$0: running $f"
^-- SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
Did you mean:
doris_note "$0: running ${f}"
In docker/runtime/be/resource/entry_point.sh line 124:
"$f"
^-- SC2250 (style): Prefer putting braces around variable
references even when not strictly required.
Did you mean:
"${f}"
In docker/runtime/be/resource/entry_point.sh line 126:
doris_note "$0: sourcing $f"
^-- SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
Did you mean:
doris_note "$0: sourcing ${f}"
In docker/runtime/be/resource/entry_point.sh line 127:
. "$f"
^--^ SC1090 (warning): ShellCheck can't follow
non-constant source. Use a directive to specify location.
^-- SC2250 (style): Prefer putting braces around variable
references even when not strictly required.
Did you mean:
. "${f}"
In docker/runtime/be/resource/entry_point.sh line 131:
doris_note "$0: running $f"
^-- SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
Did you mean:
doris_note "$0: running ${f}"
In docker/runtime/be/resource/entry_point.sh line 132:
docker_process_sql <"$f"
^-- SC2250 (style): Prefer putting braces
around variable references even when not strictly required.
Did you mean:
docker_process_sql <"${f}"
In docker/runtime/be/resource/entry_point.sh line 136:
doris_note "$0: running $f"
^-- SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
Did you mean:
doris_note "$0: running ${f}"
In docker/runtime/be/resource/entry_point.sh line 137:
bunzip2 -c "$f" | docker_process_sql
^-- SC2250 (style): Prefer putting braces around
variable references even when not strictly required.
Did you mean:
bunzip2 -c "${f}" | docker_process_sql
In docker/runtime/be/resource/entry_point.sh line 141:
doris_note "$0: running $f"
^-- SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
Did you mean:
doris_note "$0: running ${f}"
In docker/runtime/be/resource/entry_point.sh line 142:
gunzip -c "$f" | docker_process_sql
^-- SC2250 (style): Prefer putting braces around
variable references even when not strictly required.
Did you mean:
gunzip -c "${f}" | docker_process_sql
In docker/runtime/be/resource/entry_point.sh line 146:
doris_note "$0: running $f"
^-- SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
Did you mean:
doris_note "$0: running ${f}"
In docker/runtime/be/resource/entry_point.sh line 147:
xzcat "$f" | docker_process_sql
^-- SC2250 (style): Prefer putting braces around variable
references even when not strictly required.
Did you mean:
xzcat "${f}" | docker_process_sql
In docker/runtime/be/resource/entry_point.sh line 151:
doris_note "$0: running $f"
^-- SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
Did you mean:
doris_note "$0: running ${f}"
In docker/runtime/be/resource/entry_point.sh line 152:
zstd -dc "$f" | docker_process_sql
^-- SC2250 (style): Prefer putting braces around
variable references even when not strictly required.
Did you mean:
zstd -dc "${f}" | docker_process_sql
In docker/runtime/be/resource/entry_point.sh line 155:
*) doris_warn "$0: ignoring $f" ;;
^-- SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
Did you mean:
*) doris_warn "$0: ignoring ${f}" ;;
In docker/runtime/be/resource/entry_point.sh line 172:
if [ -z ${DATABASE_ALREADY_EXISTS} ]; then
^-- SC2292 (style): Prefer [[ ]] over [ ] for tests in Bash/Ksh.
^------------------------^ SC2248 (style): Prefer double quoting
even when variables don't contain special characters.
Did you mean:
if [[ -z "${DATABASE_ALREADY_EXISTS}" ]]; then
In docker/runtime/be/resource/init_be.sh line 35:
if [ "$#" -eq 0 ]; then text="$(cat)"; fi
^------------^ SC2292 (style): Prefer [[ ]] over [ ] for tests in
Bash/Ksh.
Did you mean:
if [[ "$#" -eq 0 ]]; then text="$(cat)"; fi
In docker/runtime/be/resource/init_be.sh line 36:
local dt="$(date -Iseconds)"
^-- SC2155 (warning): Declare and assign separately to avoid
masking return values.
In docker/runtime/be/resource/init_be.sh line 37:
printf '%s [%s] [Entrypoint]: %s\n' "$dt" "$type" "$text"
^-^ SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
^---^ SC2250 (style): Prefer
putting braces around variable references even when not strictly required.
^---^ SC2250 (style):
Prefer putting braces around variable references even when not strictly
required.
Did you mean:
printf '%s [%s] [Entrypoint]: %s\n' "${dt}" "${type}" "${text}"
In docker/runtime/be/resource/init_be.sh line 52:
[ "${#FUNCNAME[@]}" -ge 2 ] &&
^-------------------------^ SC2292 (style): Prefer [[ ]] over [ ] for
tests in Bash/Ksh.
Did you mean:
[[ "${#FUNCNAME[@]}" -ge 2 ]] &&
In docker/runtime/be/resource/init_be.sh line 53:
[ "${FUNCNAME[0]}" = '_is_sourced' ] &&
^-- SC2292 (style): Prefer [[ ]] over [ ] for tests in Bash/Ksh.
Did you mean:
[[ "${FUNCNAME[0]}" = '_is_sourced' ]] &&
In docker/runtime/be/resource/init_be.sh line 54:
[ "${FUNCNAME[1]}" = 'source' ]
^-----------------------------^ SC2292 (style): Prefer [[ ]] over [
] for tests in Bash/Ksh.
Did you mean:
[[ "${FUNCNAME[1]}" = 'source' ]]
In docker/runtime/be/resource/init_be.sh line 59:
if [ -d "${DORIS_HOME}/be/storage/data" ]; then
^-- SC2292 (style): Prefer [[ ]] over [ ] for tests in Bash/Ksh.
Did you mean:
if [[ -d "${DORIS_HOME}/be/storage/data" ]]; then
In docker/runtime/be/resource/init_be.sh line 66:
if [[ $FE_SERVERS =~
^.+:[1-2]{0,1}[0-9]{0,1}[0-9]{1}(\.[1-2]{0,1}[0-9]{0,1}[0-9]{1}){3}:[1-6]{0,1}[0-9]{1,4}(,.+:[1-2]{0,1}[0-9]{0,1}[0-9]{1}(\.[1-2]{0,1}[0-9]{0,1}[0-9]{1}){3}:[1-6]{0,1}[0-9]{1,4})*$
]]; then
^---------^ SC2154 (warning): FE_SERVERS is referenced but not
assigned.
^---------^ SC2250 (style): Prefer putting braces around variable
references even when not strictly required.
Did you mean:
if [[ ${FE_SERVERS} =~
^.+:[1-2]{0,1}[0-9]{0,1}[0-9]{1}(\.[1-2]{0,1}[0-9]{0,1}[0-9]{1}){3}:[1-6]{0,1}[0-9]{1,4}(,.+:[1-2]{0,1}[0-9]{0,1}[0-9]{1}(\.[1-2]{0,1}[0-9]{0,1}[0-9]{1}){3}:[1-6]{0,1}[0-9]{1,4})*$
]]; then
In docker/runtime/be/resource/init_be.sh line 67:
doris_warn "FE_SERVERS" $FE_SERVERS
^---------^ SC2086 (info): Double quote to
prevent globbing and word splitting.
^---------^ SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
Did you mean:
doris_warn "FE_SERVERS" "$FE_SERVERS"
In docker/runtime/be/resource/init_be.sh line 71:
if [[ $BE_ADDR =~
^[1-2]{0,1}[0-9]{0,1}[0-9]{1}(\.[1-2]{0,1}[0-9]{0,1}[0-9]{1}){3}:[1-6]{0,1}[0-9]{1,4}$
]]; then
^------^ SC2154 (warning): BE_ADDR is referenced but not assigned.
^------^ SC2250 (style): Prefer putting braces around variable
references even when not strictly required.
Did you mean:
if [[ ${BE_ADDR} =~
^[1-2]{0,1}[0-9]{0,1}[0-9]{1}(\.[1-2]{0,1}[0-9]{0,1}[0-9]{1}){3}:[1-6]{0,1}[0-9]{1,4}$
]]; then
In docker/runtime/be/resource/init_be.sh line 72:
doris_warn "BE_ADDR" $BE_ADDR
^------^ SC2086 (info): Double quote to prevent
globbing and word splitting.
^------^ SC2250 (style): Prefer putting braces
around variable references even when not strictly required.
Did you mean:
doris_warn "BE_ADDR" "$BE_ADDR"
In docker/runtime/be/resource/init_be.sh line 79:
local feServerArray=($(echo "${FE_SERVERS}" | awk '{gsub (/,/," ");
print $0}'))
^-- SC2207 (warning): Prefer mapfile or read -a to
split command output (or quote to avoid splitting).
In docker/runtime/be/resource/init_be.sh line 86:
check_arg "tmpFeIp" $tmpFeIp
^------^ SC2086 (info): Double quote to prevent
globbing and word splitting.
^------^ SC2250 (style): Prefer putting braces
around variable references even when not strictly required.
Did you mean:
check_arg "tmpFeIp" "$tmpFeIp"
In docker/runtime/be/resource/init_be.sh line 87:
feIpArray[$tmpFeId]=${tmpFeIp}
^------^ SC2250 (style): Prefer putting braces around
variable references even when not strictly required.
Did you mean:
feIpArray[${tmpFeId}]=${tmpFeIp}
In docker/runtime/be/resource/init_be.sh line 88:
check_arg "tmpFeEditLogPort" $tmpFeEditLogPort
^---------------^ SC2086 (info): Double
quote to prevent globbing and word splitting.
^---------------^ SC2250 (style):
Prefer putting braces around variable references even when not strictly
required.
Did you mean:
check_arg "tmpFeEditLogPort" "$tmpFeEditLogPort"
In docker/runtime/be/resource/init_be.sh line 89:
feEditLogPortArray[$tmpFeId]=${tmpFeEditLogPort}
^------^ SC2250 (style): Prefer putting braces
around variable references even when not strictly required.
Did you mean:
feEditLogPortArray[${tmpFeId}]=${tmpFeEditLogPort}
In docker/runtime/be/resource/init_be.sh line 94:
check_arg "MASTER_FE_IP" $MASTER_FE_IP
^-----------^ SC2086 (info): Double quote to
prevent globbing and word splitting.
^-----------^ SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
Did you mean:
check_arg "MASTER_FE_IP" "$MASTER_FE_IP"
In docker/runtime/be/resource/init_be.sh line 96:
check_arg "BE_HOST_IP" $BE_HOST_IP
^---------^ SC2086 (info): Double quote to
prevent globbing and word splitting.
^---------^ SC2250 (style): Prefer putting braces
around variable references even when not strictly required.
Did you mean:
check_arg "BE_HOST_IP" "$BE_HOST_IP"
In docker/runtime/be/resource/init_be.sh line 98:
check_arg "BE_HEARTBEAT_PORT" $BE_HEARTBEAT_PORT
^----------------^ SC2086 (info): Double
quote to prevent globbing and word splitting.
^----------------^ SC2250 (style): Prefer
putting braces around variable references even when not strictly required.
Did you mean:
check_arg "BE_HEARTBEAT_PORT" "$BE_HEARTBEAT_PORT"
In docker/runtime/be/resource/init_be.sh line 101:
check_arg "priority_networks" $PRIORITY_NETWORKS
^----------------^ SC2086 (info): Double
quote to prevent globbing and word splitting.
^----------------^ SC2250 (style): Prefer
putting braces around variable references even when not strictly required.
Did you mean:
check_arg "priority_networks" "$PRIORITY_NETWORKS"
In docker/runtime/be/resource/init_be.sh line 114:
echo "priority_networks = ${1}" >>${DORIS_HOME}/be/conf/be.conf
^-----------^ SC2248 (style): Prefer
double quoting even when variables don't contain special characters.
Did you mean:
echo "priority_networks = ${1}" >>"${DORIS_HOME}"/be/conf/be.conf
In docker/runtime/be/resource/init_be.sh line 121:
mysql -uroot -P9030 -h${MASTER_FE_IP} --comments "$@" >2 &
^-------------^ SC2086 (info): Double quote to
prevent globbing and word splitting.
^-- SC2210
(warning): This is a file redirection. Was it supposed to be a comparison or fd
operation?
Did you mean:
mysql -uroot -P9030 -h"${MASTER_FE_IP}" --comments "$@" >2 &
In docker/runtime/be/resource/init_be.sh line 122:
1>/dev/null
^---------^ SC2188 (warning): This redirection doesn't have a command.
Move to its command (or use 'true' as no-op).
In docker/runtime/be/resource/init_be.sh line 130:
if [[ $(($i % 20)) == 1 ]]; then
^-- SC2004 (style): $/${} is unnecessary on arithmetic
variables.
^-- SC2250 (style): Prefer putting braces around variable
references even when not strictly required.
Did you mean:
if [[ $((${i} % 20)) == 1 ]]; then
In docker/runtime/be/resource/init_be.sh line 135:
if [[ $register_be_status == 0 ]]; then
^-----------------^ SC2250 (style): Prefer putting braces
around variable references even when not strictly required.
Did you mean:
if [[ ${register_be_status} == 0 ]]; then
In docker/runtime/be/resource/init_be.sh line 141:
if [ -n "$BE_ALREADY_EXISTS" ]; then
^-------------------------^ SC2292 (style): Prefer [[ ]] over
[ ] for tests in Bash/Ksh.
^----------------^ SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
Did you mean:
if [[ -n "${BE_ALREADY_EXISTS}" ]]; then
In docker/runtime/be/resource/init_be.sh line 145:
if [[ $(($i % 20)) == 1 ]]; then
^-- SC2004 (style): $/${} is unnecessary on arithmetic
variables.
^-- SC2250 (style): Prefer putting braces around
variable references even when not strictly required.
Did you mean:
if [[ $((${i} % 20)) == 1 ]]; then
In docker/runtime/be/resource/init_be.sh line 152:
if ! [[ $is_fe_start ]]; then
^----------^ SC2244 (style): Prefer explicit -n to check
non-empty string (or use =/-ne to check boolean/integer).
^----------^ SC2250 (style): Prefer putting braces around
variable references even when not strictly required.
Did you mean:
if ! [[ -n $is_fe_start ]]; then
In docker/runtime/be/resource/init_be.sh line 160:
if [ -z $2 ]; then
^-------^ SC2292 (style): Prefer [[ ]] over [ ] for tests in Bash/Ksh.
^-- SC2086 (info): Double quote to prevent globbing and word
splitting.
Did you mean:
if [[ -z "$2" ]]; then
In docker/runtime/be/resource/init_be.sh line 169:
if [[ $(($i % 20)) == 1 ]]; then
^-- SC2004 (style): $/${} is unnecessary on arithmetic
variables.
^-- SC2250 (style): Prefer putting braces around variable
references even when not strictly required.
Did you mean:
if [[ $((${i} % 20)) == 1 ]]; then
In docker/runtime/be/resource/init_be.sh line 200:
if [ -z "$DATABASE_ALREADY_EXISTS" ]; then
^-- SC2292 (style): Prefer [[ ]] over [ ] for tests in Bash/Ksh.
^----------------------^ SC2250 (style): Prefer putting braces
around variable references even when not strictly required.
Did you mean:
if [[ -z "${DATABASE_ALREADY_EXISTS}" ]]; then
In docker/runtime/be/resource/init_be.sh line 201:
add_priority_networks $PRIORITY_NETWORKS
^----------------^ SC2086 (info): Double quote
to prevent globbing and word splitting.
^----------------^ SC2250 (style): Prefer
putting braces around variable references even when not strictly required.
Did you mean:
add_priority_networks "$PRIORITY_NETWORKS"
In docker/runtime/fe/resource/init_fe.sh line 35:
if [ "$#" -eq 0 ]; then text="$(cat)"; fi
^------------^ SC2292 (style): Prefer [[ ]] over [ ] for tests in
Bash/Ksh.
Did you mean:
if [[ "$#" -eq 0 ]]; then text="$(cat)"; fi
In docker/runtime/fe/resource/init_fe.sh line 36:
local dt="$(date -Iseconds)"
^-- SC2155 (warning): Declare and assign separately to avoid
masking return values.
In docker/runtime/fe/resource/init_fe.sh line 37:
printf '%s [%s] [Entrypoint]: %s\n' "$dt" "$type" "$text"
^-^ SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
^---^ SC2250 (style): Prefer
putting braces around variable references even when not strictly required.
^---^ SC2250 (style):
Prefer putting braces around variable references even when not strictly
required.
Did you mean:
printf '%s [%s] [Entrypoint]: %s\n' "${dt}" "${type}" "${text}"
In docker/runtime/fe/resource/init_fe.sh line 52:
[ "${#FUNCNAME[@]}" -ge 2 ] &&
^-------------------------^ SC2292 (style): Prefer [[ ]] over [ ] for
tests in Bash/Ksh.
Did you mean:
[[ "${#FUNCNAME[@]}" -ge 2 ]] &&
In docker/runtime/fe/resource/init_fe.sh line 53:
[ "${FUNCNAME[0]}" = '_is_sourced' ] &&
^-- SC2292 (style): Prefer [[ ]] over [ ] for tests in Bash/Ksh.
Did you mean:
[[ "${FUNCNAME[0]}" = '_is_sourced' ]] &&
In docker/runtime/fe/resource/init_fe.sh line 54:
[ "${FUNCNAME[1]}" = 'source' ]
^-----------------------------^ SC2292 (style): Prefer [[ ]] over [
] for tests in Bash/Ksh.
Did you mean:
[[ "${FUNCNAME[1]}" = 'source' ]]
In docker/runtime/fe/resource/init_fe.sh line 59:
if [ -d "${DORIS_HOME}/fe/doris-meta/image" ]; then
^-- SC2292 (style): Prefer [[ ]] over [ ] for tests in Bash/Ksh.
Did you mean:
if [[ -d "${DORIS_HOME}/fe/doris-meta/image" ]]; then
In docker/runtime/fe/resource/init_fe.sh line 66:
if [[ $FE_SERVERS =~
^.+:[1-2]{0,1}[0-9]{0,1}[0-9]{1}(\.[1-2]{0,1}[0-9]{0,1}[0-9]{1}){3}:[1-6]{0,1}[0-9]{1,4}(,.+:[1-2]{0,1}[0-9]{0,1}[0-9]{1}(\.[1-2]{0,1}[0-9]{0,1}[0-9]{1}){3}:[1-6]{0,1}[0-9]{1,4})*$
]]; then
^---------^ SC2154 (warning): FE_SERVERS is referenced but not
assigned.
^---------^ SC2250 (style): Prefer putting braces around variable
references even when not strictly required.
Did you mean:
if [[ ${FE_SERVERS} =~
^.+:[1-2]{0,1}[0-9]{0,1}[0-9]{1}(\.[1-2]{0,1}[0-9]{0,1}[0-9]{1}){3}:[1-6]{0,1}[0-9]{1,4}(,.+:[1-2]{0,1}[0-9]{0,1}[0-9]{1}(\.[1-2]{0,1}[0-9]{0,1}[0-9]{1}){3}:[1-6]{0,1}[0-9]{1,4})*$
]]; then
In docker/runtime/fe/resource/init_fe.sh line 67:
doris_warn "FE_SERVERS" $FE_SERVERS
^---------^ SC2086 (info): Double quote to
prevent globbing and word splitting.
^---------^ SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
Did you mean:
doris_warn "FE_SERVERS" "$FE_SERVERS"
In docker/runtime/fe/resource/init_fe.sh line 71:
if [[ $FE_ID =~ ^[1-9]{1}$ ]]; then
^----^ SC2154 (warning): FE_ID is referenced but not assigned.
^----^ SC2250 (style): Prefer putting braces around variable
references even when not strictly required.
Did you mean:
if [[ ${FE_ID} =~ ^[1-9]{1}$ ]]; then
In docker/runtime/fe/resource/init_fe.sh line 72:
doris_warn "FE_ID" $FE_ID
^----^ SC2086 (info): Double quote to prevent
globbing and word splitting.
^----^ SC2250 (style): Prefer putting braces
around variable references even when not strictly required.
Did you mean:
doris_warn "FE_ID" "$FE_ID"
In docker/runtime/fe/resource/init_fe.sh line 79:
local feServerArray=($(echo "${FE_SERVERS}" | awk '{gsub (/,/," ");
print $0}'))
^-- SC2207 (warning): Prefer mapfile or read -a to
split command output (or quote to avoid splitting).
In docker/runtime/fe/resource/init_fe.sh line 86:
check_arg "TMP_FE_NAME" $tmpFeName
^--------^ SC2086 (info): Double quote to
prevent globbing and word splitting.
^--------^ SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
Did you mean:
check_arg "TMP_FE_NAME" "$tmpFeName"
In docker/runtime/fe/resource/init_fe.sh line 87:
feIpArray[$tmpFeName]=${tmpFeIp}
^--------^ SC2250 (style): Prefer putting braces around
variable references even when not strictly required.
Did you mean:
feIpArray[${tmpFeName}]=${tmpFeIp}
In docker/runtime/fe/resource/init_fe.sh line 88:
check_arg "TMP_FE_EDIT_LOG_PORT" $tmpFeEditLogPort
^---------------^ SC2086 (info):
Double quote to prevent globbing and word splitting.
^---------------^ SC2250 (style):
Prefer putting braces around variable references even when not strictly
required.
Did you mean:
check_arg "TMP_FE_EDIT_LOG_PORT" "$tmpFeEditLogPort"
In docker/runtime/fe/resource/init_fe.sh line 89:
feEditLogPortArray[$tmpFeName]=${tmpFeEditLogPort}
^--------^ SC2250 (style): Prefer putting braces
around variable references even when not strictly required.
Did you mean:
feEditLogPortArray[${tmpFeName}]=${tmpFeEditLogPort}
In docker/runtime/fe/resource/init_fe.sh line 94:
check_arg "MASTER_FE_IP" $MASTER_FE_IP
^-----------^ SC2086 (info): Double quote to
prevent globbing and word splitting.
^-----------^ SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
Did you mean:
check_arg "MASTER_FE_IP" "$MASTER_FE_IP"
In docker/runtime/fe/resource/init_fe.sh line 96:
check_arg "MASTER_FE_EDIT_PORT" $MASTER_FE_EDIT_PORT
^------------------^ SC2086 (info):
Double quote to prevent globbing and word splitting.
^------------------^ SC2250 (style):
Prefer putting braces around variable references even when not strictly
required.
Did you mean:
check_arg "MASTER_FE_EDIT_PORT" "$MASTER_FE_EDIT_PORT"
In docker/runtime/fe/resource/init_fe.sh line 98:
check_arg "CURRENT_FE_IP" $CURRENT_FE_IP
^------------^ SC2086 (info): Double quote to
prevent globbing and word splitting.
^------------^ SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
Did you mean:
check_arg "CURRENT_FE_IP" "$CURRENT_FE_IP"
In docker/runtime/fe/resource/init_fe.sh line 100:
check_arg "CURRENT_FE_EDIT_PORT" $CURRENT_FE_EDIT_PORT
^-------------------^ SC2086 (info):
Double quote to prevent globbing and word splitting.
^-------------------^ SC2250 (style):
Prefer putting braces around variable references even when not strictly
required.
Did you mean:
check_arg "CURRENT_FE_EDIT_PORT" "$CURRENT_FE_EDIT_PORT"
In docker/runtime/fe/resource/init_fe.sh line 102:
if [ ${MASTER_FE_IP} == ${CURRENT_FE_IP} ]; then
^-- SC2292 (style): Prefer [[ ]] over [ ] for tests in Bash/Ksh.
^-------------^ SC2086 (info): Double quote to prevent globbing and
word splitting.
^--------------^ SC2086 (info): Double quote to
prevent globbing and word splitting.
Did you mean:
if [[ "${MASTER_FE_IP}" == "${CURRENT_FE_IP}" ]]; then
In docker/runtime/fe/resource/init_fe.sh line 109:
check_arg "PRIORITY_NETWORKS" $PRIORITY_NETWORKS
^----------------^ SC2086 (info): Double
quote to prevent globbing and word splitting.
^----------------^ SC2250 (style): Prefer
putting braces around variable references even when not strictly required.
Did you mean:
check_arg "PRIORITY_NETWORKS" "$PRIORITY_NETWORKS"
In docker/runtime/fe/resource/init_fe.sh line 122:
echo "priority_networks = ${1}" >>${DORIS_HOME}/fe/conf/fe.conf
^-----------^ SC2248 (style): Prefer
double quoting even when variables don't contain special characters.
Did you mean:
echo "priority_networks = ${1}" >>"${DORIS_HOME}"/fe/conf/fe.conf
In docker/runtime/fe/resource/init_fe.sh line 129:
mysql -uroot -P9030 -h${MASTER_FE_IP} --comments "$@" 2>/dev/null
^-------------^ SC2086 (info): Double quote to
prevent globbing and word splitting.
Did you mean:
mysql -uroot -P9030 -h"${MASTER_FE_IP}" --comments "$@" 2>/dev/null
In docker/runtime/fe/resource/init_fe.sh line 136:
if [ ${CURRENT_FE_IS_MASTER} == true ]; then
^-- SC2292 (style): Prefer [[ ]] over [ ] for tests in Bash/Ksh.
^---------------------^ SC2248 (style): Prefer double quoting even
when variables don't contain special characters.
Did you mean:
if [[ "${CURRENT_FE_IS_MASTER}" == true ]]; then
In docker/runtime/fe/resource/init_fe.sh line 141:
if [[ $(($i % 20)) == 1 ]]; then
^-- SC2004 (style): $/${} is unnecessary on arithmetic
variables.
^-- SC2250 (style): Prefer putting braces around variable
references even when not strictly required.
Did you mean:
if [[ $((${i} % 20)) == 1 ]]; then
In docker/runtime/fe/resource/init_fe.sh line 146:
if [[ $register_fe_status == 0 ]]; then
^-----------------^ SC2250 (style): Prefer putting braces
around variable references even when not strictly required.
Did you mean:
if [[ ${register_fe_status} == 0 ]]; then
In docker/runtime/fe/resource/init_fe.sh line 152:
if [ -n "$CURRENT_FE_ALREADY_EXISTS" ]; then
^-- SC2292 (style): Prefer [[ ]] over [ ] for tests in
Bash/Ksh.
^------------------------^ SC2250 (style): Prefer
putting braces around variable references even when not strictly required.
Did you mean:
if [[ -n "${CURRENT_FE_ALREADY_EXISTS}" ]]; then
In docker/runtime/fe/resource/init_fe.sh line 156:
if [[ $(($i % 20)) == 1 ]]; then
^-- SC2004 (style): $/${} is unnecessary on arithmetic
variables.
^-- SC2250 (style): Prefer putting braces around
variable references even when not strictly required.
Did you mean:
if [[ $((${i} % 20)) == 1 ]]; then
In docker/runtime/fe/resource/init_fe.sh line 163:
if ! [[ $is_fe_start ]]; then
^----------^ SC2244 (style): Prefer explicit -n to check
non-empty string (or use =/-ne to check boolean/integer).
^----------^ SC2250 (style): Prefer putting braces around
variable references even when not strictly required.
Did you mean:
if ! [[ -n $is_fe_start ]]; then
In docker/runtime/fe/resource/init_fe.sh line 171:
if [ -z $2 ]; then
^-------^ SC2292 (style): Prefer [[ ]] over [ ] for tests in Bash/Ksh.
^-- SC2086 (info): Double quote to prevent globbing and word
splitting.
Did you mean:
if [[ -z "$2" ]]; then
In docker/runtime/fe/resource/init_fe.sh line 180:
if [ ${CURRENT_FE_IS_MASTER} == true ]; then
^-- SC2292 (style): Prefer [[ ]] over [ ] for tests in Bash/Ksh.
^---------------------^ SC2248 (style): Prefer double quoting even
when variables don't contain special characters.
Did you mean:
if [[ "${CURRENT_FE_IS_MASTER}" == true ]]; then
In docker/runtime/fe/resource/init_fe.sh line 185:
if [[ $(($i % 20)) == 1 ]]; then
^-- SC2004 (style): $/${} is unnecessary on arithmetic
variables.
^-- SC2250 (style): Prefer putting braces around variable
references even when not strictly required.
Did you mean:
if [[ $((${i} % 20)) == 1 ]]; then
In docker/runtime/fe/resource/init_fe.sh line 203:
if [[ $(($i % 20)) == 1 ]]; then
^-- SC2004 (style): $/${} is unnecessary on arithmetic
variables.
^-- SC2250 (style): Prefer putting braces around
variable references even when not strictly required.
Did you mean:
if [[ $((${i} % 20)) == 1 ]]; then
In docker/runtime/fe/resource/init_fe.sh line 220:
if [ -z "$DATABASE_ALREADY_EXISTS" ]; then
^-- SC2292 (style): Prefer [[ ]] over [ ] for tests in Bash/Ksh.
^----------------------^ SC2250 (style): Prefer putting braces
around variable references even when not strictly required.
Did you mean:
if [[ -z "${DATABASE_ALREADY_EXISTS}" ]]; then
In docker/runtime/fe/resource/init_fe.sh line 221:
add_priority_networks $PRIORITY_NETWORKS
^----------------^ SC2086 (info): Double quote
to prevent globbing and word splitting.
^----------------^ SC2250 (style): Prefer
putting braces around variable references even when not strictly required.
Did you mean:
add_priority_networks "$PRIORITY_NETWORKS"
In docker/runtime/fe/resource/init_fe.sh line 228:
if [ $CURRENT_FE_IS_MASTER == true ]; then
^-- SC2292 (style): Prefer [[ ]] over [ ] for tests in Bash/Ksh.
^-------------------^ SC2248 (style): Prefer double quoting even
when variables don't contain special characters.
^-------------------^ SC2250 (style): Prefer putting braces around
variable references even when not strictly required.
Did you mean:
if [[ "$CURRENT_FE_IS_MASTER" == true ]]; then
In docker/runtime/fe/resource/init_fe.sh line 231:
start_fe.sh --helper ${MASTER_FE_IP}:${MASTER_FE_EDIT_PORT}
^-------------^ SC2086 (info): Double quote to
prevent globbing and word splitting.
^--------------------^ SC2086
(info): Double quote to prevent globbing and word splitting.
Did you mean:
start_fe.sh --helper "${MASTER_FE_IP}":"${MASTER_FE_EDIT_PORT}"
For more information:
https://www.shellcheck.net/wiki/SC1090 -- ShellCheck can't follow
non-const...
https://www.shellcheck.net/wiki/SC2154 -- BE_ADDR is referenced but not
ass...
https://www.shellcheck.net/wiki/SC2155 -- Declare and assign separately to
...
----------
You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
# shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.
```
</details>
<details>
<summary>shfmt errors</summary>
```
'shfmt ' found no issues.
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
