github-actions[bot] commented on code in PR #68406: URL: https://github.com/apache/doris/pull/68406#discussion_r4079110237
########## LICENSE.txt: ########## @@ -412,32 +412,6 @@ SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. ------------------------------------------------------------------------------- -be/src/util/utf8_check.cpp: MIT license Review Comment: [P1] Complete the binary-license update for the new implementation This removes the retired source notice only from the source-tree `LICENSE.txt`, but `dist/LICENSE-dist.txt` still ships the Yibo Cai MIT block for `utf8_check.cpp`, and `build.sh` copies that manifest into every binary output. More importantly, this first live call into the single-object `libsimdutf.a` also links its runtime ISA detector: simdutf v9.2.0's `include/simdutf/internal/isadetection.h` carries a 3-clause BSD notice whose second condition requires reproduction with binary distributions, while Doris's shipped license materials list simdutf only as Apache-2.0 and contain none of the named notice. Please add that BSD notice to the distribution license payload, remove the stale MIT block, and remove the obsolete `utf8_check.cpp` entries from `.rat-excludes` and `.licenserc.yaml` so the rewritten ASF file is covered by the license gates. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
