TangSiyang2001 commented on PR #16343: URL: https://github.com/apache/doris/pull/16343#issuecomment-1423497510
> Nice work, thanks for your contribution. I've two suggestion here: > > 1. please add some unit test, there are some cases relate to `query_timeout` in FE's code, you can refer to them. > > 2. in some regression test, e.g. `regression-test/suites/ssb_sf0.1_p1/load.groovy`, we set `query_timeout` to 3600 to make sure the insert into select statement can execute success, we can replace all of these options to `insert_timeout`. Recieved, will be done later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
