OIiveirra commented on code in PR #68276:
URL: https://github.com/apache/doris/pull/68276#discussion_r4068159237
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/iceberg/IcebergUtils.java:
##########
@@ -1132,7 +1132,8 @@ private static String
serializePartitionValue(org.apache.iceberg.types.Type type
long timestampMicros = (Long) value;
TimestampType timestampType = (TimestampType) type;
LocalDateTime timestamp = LocalDateTime.ofEpochSecond(
- timestampMicros / 1_000_000, (int) (timestampMicros %
1_000_000) * 1000,
+ Math.floorDiv(timestampMicros, 1_000_000L),
+ Math.toIntExact(Math.floorMod(timestampMicros,
1_000_000L) * 1_000L),
Review Comment:
Fixed in 6a57c6d4fdf. For `$position_deletes.partition` only,
mapping-enabled Iceberg `timestamptz` values are now transported as an
unambiguous UTC ISO-8601 instant (for example, `-1` microsecond becomes
`1969-12-31T23:59:59.999999Z`) instead of a session-local offsetless timestamp.
Added a regression test with `Asia/Shanghai` and a negative identity partition;
the complete `IcebergScanNodeTest` passed (95 tests, 0 failures/errors/skips).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
