HappenLee commented on code in PR #67817:
URL: https://github.com/apache/doris/pull/67817#discussion_r4059743422
##########
be/test/storage/segment/column_reader_test.cpp:
##########
@@ -450,6 +474,204 @@ TEST_F(ColumnReaderTest,
NullMapOnlyReadBySparseRowidsAcrossPages) {
EXPECT_EQ(2, nullable_col.get_nested_column().size());
}
+TEST_F(ColumnReaderTest, ArrayReadByRowidsMatchesSequentialReadAcrossPages) {
Review Comment:
**Additional coverage for nested arrays and schema evolution**
The real-file test covers nullable `ARRAY<nullable INT>`, including the
predicate/filter/lazy sequence. Could we extend coverage to `ARRAY<ARRAY<...>>`
and `ARRAY<STRUCT<...>>`, and add a case that reads an old non-nullable ARRAY
segment into a nullable destination after schema evolution?
For the nested cases, please exercise predicate materialization, row
filtering, and lazy filling of the remaining children, and compare the final
result with a full sequential read. This should verify that
already-materialized offsets/null maps remain unchanged and that child data
stays aligned across multiple selected ranges. A SQL regression for nested lazy
materialization would also verify that planner access paths reach the intended
reader phases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
