924060929 commented on code in PR #66913:
URL: https://github.com/apache/doris/pull/66913#discussion_r4059409720
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/iceberg/rewrite/RewriteGroupTask.java:
##########
@@ -186,6 +212,9 @@ private void executeGroup(ConnectContext taskConnectContext,
StatementBase taskParsedStmt) throws Exception {
// Step 1: Create stmt executor
stmtExecutor = new StmtExecutor(taskConnectContext, taskParsedStmt);
+ if (isCanceled.get()) {
Review Comment:
Follow-up after tracing the remaining handoff window: no further change
belongs in this PR.
This PR already publishes the rewrite coordinator, so cancellation after
publication reaches running BE work. The stricter
cancel-before-coordinator-publication guarantee requires generic
StmtExecutor/Coordinator terminal-state and pre-dispatch semantics. That
concern predates and is independent of this PR's Iceberg/Hudi
generation-resource ownership.
For the lifecycle scope here, RewriteGroupTask retains WritableTableLease
until its execution actually exits, so catalog reset cannot close the retained
Iceberg generation while the task is still active. We will not broaden this
resource-lifecycle PR with the generic query-cancellation architecture change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
