airborne12 commented on code in PR #67918:
URL: https://github.com/apache/doris/pull/67918#discussion_r4059376521
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/InvertedIndexUtil.java:
##########
@@ -423,17 +445,27 @@ public static boolean isAnalyzerMatched(Map<String,
String> properties, String a
buildAnalyzerIdentity(properties));
}
+ String resolvedAnalyzer = resolveAnalyzerName(normalizedAnalyzer);
String preferredAnalyzer =
InvertedIndexProperties.getPreferredAnalyzer(properties);
if (!Strings.isNullOrEmpty(preferredAnalyzer)) {
- return normalizedAnalyzer.equalsIgnoreCase(preferredAnalyzer);
Review Comment:
Fixed in `298168706baf432dc7fcfb91fd080e02cc1957bc`. FE now rejects
duplicate non-IK analyzer selectors before comparing full analyzer identities,
so two indexes cannot remain ambiguous merely because their outer char filters
differ. This covers both explicit selectors such as `standard` and the implicit
default selector in CREATE TABLE and ALTER ADD INDEX paths. Added unit coverage
for explicit and implicit selectors with different outer filters, plus
CREATE/ALTER regression coverage. Validation: `InvertedIndexPropertiesTest`
58/58, targeted analyzer regression 1/1, and the FE reactor build passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
