HappenLee commented on code in PR #16496:
URL: https://github.com/apache/doris/pull/16496#discussion_r1099735137
##########
regression-test/suites/jdbc_p0/test_jdbc_query_mysql.groovy:
##########
@@ -934,14 +935,14 @@ suite("test_jdbc_query_mysql", "p0") {
order_qt_sql111 """ SELECT rank() OVER () FROM (SELECT k8 FROM
$jdbcMysql57Table1 LIMIT 10) as t LIMIT 3 """
order_qt_sql112 """ SELECT k7, count(DISTINCT k8) FROM
$jdbcMysql57Table1 WHERE k8 > 110 GROUP BY GROUPING SETS ((), (k7)) """
-
+ // test this action result need restart?
// test alter resource
- sql """alter resource $jdbcResourceMysql57 properties("password" =
"1234567")"""
- test {
- sql """select count(*) from $jdbcMysql57Table1"""
- exception "Access denied for user"
- }
- sql """alter resource $jdbcResourceMysql57 properties("password" =
"123456")"""
+ // sql """alter resource $jdbcResourceMysql57 properties("password" =
"1234567")"""
Review Comment:
why disable the check
##########
regression-test/suites/jdbc_p0/test_jdbc_query_mysql.groovy:
##########
@@ -934,14 +935,14 @@ suite("test_jdbc_query_mysql", "p0") {
order_qt_sql111 """ SELECT rank() OVER () FROM (SELECT k8 FROM
$jdbcMysql57Table1 LIMIT 10) as t LIMIT 3 """
order_qt_sql112 """ SELECT k7, count(DISTINCT k8) FROM
$jdbcMysql57Table1 WHERE k8 > 110 GROUP BY GROUPING SETS ((), (k7)) """
-
+ // test this action result need restart?
// test alter resource
- sql """alter resource $jdbcResourceMysql57 properties("password" =
"1234567")"""
- test {
- sql """select count(*) from $jdbcMysql57Table1"""
- exception "Access denied for user"
- }
- sql """alter resource $jdbcResourceMysql57 properties("password" =
"123456")"""
+ // sql """alter resource $jdbcResourceMysql57 properties("password" =
"1234567")"""
Review Comment:
why disable the check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
