github-actions[bot] commented on code in PR #66913:
URL: https://github.com/apache/doris/pull/66913#discussion_r4057513828
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/iceberg/IcebergExternalMetaCache.java:
##########
@@ -480,13 +875,18 @@ private SchemaCacheValue
loadSchemaCacheValue(IcebergSchemaCacheKey key) {
Review Comment:
[P1] Keep contextual view schema conversion on the retained generation
This new miss loader passes a retained table and captured mapping flags only
for the table branch. The view branch at this line calls
`IcebergUtils.loadSchemaCacheValue(..., true, retainedTable)`, but that
overload ignores `retainedTable` and routes through
`loadViewSchemaCacheValue()`/`getSchema(..., null)`, which reacquires the live
view, authenticator, and `getEnableMapping*()` flags. If ALTER/reset flips a
mapping option while the miss is converting, the cached schema can describe G1
with G2 semantics while the scan/transport still uses G1. Carry the retained
view plus its captured authenticator/options through this branch (or make the
entry contextual-only), and add a reset-barrier regression.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
