924060929 commented on code in PR #66913: URL: https://github.com/apache/doris/pull/66913#discussion_r4056308900
########## fe/fe-core/src/main/java/org/apache/doris/datasource/iceberg/IcebergExternalMetaCache.java: ########## @@ -37,7 +37,11 @@ import org.apache.doris.datasource.metacache.MetaCacheSizeEstimate; import org.apache.doris.datasource.metacache.MetaCacheSizeEstimator; import org.apache.doris.mtmv.MTMVRelatedTableIf; +import org.apache.doris.nereids.StatementContext; +import org.apache.doris.qe.ConnectContext; +import com.google.common.annotations.VisibleForTesting; +import com.google.common.base.Preconditions; import org.apache.commons.lang3.exception.ExceptionUtils; Review Comment: Rebase update: the same P1 fix is now commit 45008afa6e7 on head b6f05bedd3d after rebasing onto branch-4.1 at 35791e3b692. The scoped display-schema borrower and exact-generation authentication are unchanged. ########## fe/fe-core/src/main/java/org/apache/doris/datasource/iceberg/IcebergExternalMetaCache.java: ########## @@ -37,7 +37,11 @@ import org.apache.doris.datasource.metacache.MetaCacheSizeEstimate; import org.apache.doris.datasource.metacache.MetaCacheSizeEstimator; import org.apache.doris.mtmv.MTMVRelatedTableIf; +import org.apache.doris.nereids.StatementContext; +import org.apache.doris.qe.ConnectContext; +import com.google.common.annotations.VisibleForTesting; +import com.google.common.base.Preconditions; import org.apache.commons.lang3.exception.ExceptionUtils; import org.apache.iceberg.ManifestContent; Review Comment: Rebase update: the same P2 manifest-cache fix is now commit 45008afa6e7 on head b6f05bedd3d after rebasing onto branch-4.1 at 35791e3b692. The retired-reader final cache drop and deterministic race test are unchanged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
