github-actions[bot] commented on code in PR #67417:
URL: https://github.com/apache/doris/pull/67417#discussion_r4056195086
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/hive/HMSExternalCatalog.java:
##########
@@ -197,15 +197,24 @@ public HMSCachedClient getClient() {
@Override
public void registerDatabase(long dbId, String dbName) {
+ registerDatabaseFromEvent(dbId, dbName, acquireMetadataLoadEpoch());
+ }
+
+ public boolean registerDatabaseFromEvent(long dbId, String dbName, long
metadataLoadEpoch) {
if (LOG.isDebugEnabled()) {
LOG.debug("create database [{}]", dbName);
}
+ if (!isDatabaseAllowedByFilter(dbName)) {
Review Comment:
[P1] Match event-name casing when applying database filters
Production `MetastoreEvent(NotificationEvent, ...)` lowercases
`event.getDbName()` before `CreateDatabaseEvent` calls this method. The
configured include/exclude maps preserve their spelling, and the full snapshot
filters the original remote name, so `exclude_database_list=ExcludedDb` with a
remote `ExcludedDb` arrives here as `excludeddb`, passes this exact-case check,
and `updateCache` publishes the excluded database. Normalize the event/filter
comparison consistently and add a production-shaped mixed-case create-event
regression. This is distinct from the earlier filter thread because the new
admission check exists but is bypassed by event normalization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
