yiguolei commented on code in PR #68198:
URL: https://github.com/apache/doris/pull/68198#discussion_r4055918524
##########
be/src/exec/rowid_fetcher.cpp:
##########
@@ -1043,10 +1039,19 @@ Status RowIdStorageReader::read_doris_format_row(
iterator_item.storage_read_options.io_ctx.file_cache_miss_policy =
file_cache_miss_policy;
}
- set_slot_access_paths(slots[x], full_read_schema,
iterator_item.storage_read_options);
- RETURN_IF_ERROR(segment->seek_and_read_by_rowid(
- full_read_schema, &slots[x], row_ids, column,
- iterator_item.storage_read_options,
iterator_item.iterator));
+ int32_t index = slots[x].col_unique_id() >= 0
Review Comment:
TabletSchema full_read_schema;
for (const ColumnPB& column_pb : request_block_desc.column_descs()) {
full_read_schema.append_column(TabletColumn(column_pb));
}
这里的full read schema 是这么来的。 感觉我们这里似乎又从这个full read schema 中拿出单个的tablet
column，那直接从上层把这个pb 传递下来，似乎就直接对了？ 或者直接传递一个vector的tablet column？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
