eldenmoon opened a new pull request, #68232:
URL: https://github.com/apache/doris/pull/68232
### What problem does this PR solve?
Issue Number: None
Related PR: #66858
Problem Summary: After #66858 enabled Variant V2 by default, the V1 JSON
parser in `be/src/util/json/json_parser.{h,cpp}` (`JSONDataParser`,
`ParseConfig`, `ParseResult` and the `getValueAsField`/`writeValueAsJsonb`
helpers) has no production caller; only tests still referenced it.
This PR removes:
- the parser itself (`be/src/util/json/json_parser.{h,cpp}`), including its
`extern template class JSONDataParser<SimdJSONParser>` declaration and the
matching explicit instantiation;
- its dedicated test `be/test/core/jsonb/json_parser_test.cpp`, which
covered nothing else;
- the stale `#include "util/json/json_parser.h"` lines left in
`segment_creator.cpp`, `function_variant_parse.cpp`, `variant_util.cpp`,
`cast_to_decimal128_perf.cpp` and `index_storage_test_util.h`;
- the never-read `IndexBatch::parse_to` test field (of type
`ParseConfig::ParseTo`) and its single assignment in
`index_storage_variant_debug_point_test.cpp`.
`be/test/util/variant/variant_field_test.cpp` contained one case comparing
the V1 parser against the V2 encoder; only its V2 `encode_json` assertions are
kept, renamed to `VariantFieldTest.EncodeJsonStableSubset`.
`util/json/simd_json_parser.h` and `util/json/path_in_data.{h,cpp}` are
kept, as both still have production users.
Note: `be/benchmark/benchmark_variant_segment.hpp` also references
`ParseConfig`, but its V1 branch already fails to compile on master (it calls
`ColumnVariant`, `variant_util::parse_json_to_variant` and
`variant_util::select_storage_variant_parse_target`, none of which exist any
more). It is built only with the BE benchmark target and is left for a separate
fix.
### Release note
None
### Check List (For Author)
- Test: Unit Test
- `build-support/check-build-hygiene.sh` passed
- ASAN BE build (`./build.sh --be`) passed
- `./run-be-ut.sh --run --filter='VariantFieldTest.*:IndexStorage*'`
passed: 83 passed, 2 pre-existing skips
- Behavior changed: No
- Does this need documentation: No
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
