github-actions[bot] commented on code in PR #68182:
URL: https://github.com/apache/doris/pull/68182#discussion_r4045615244
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/ConcatWs.java:
##########
@@ -35,7 +36,7 @@
* ScalarFunction 'concat_ws'. This class is generated by GenerateFunction.
*/
public class ConcatWs extends ScalarFunction
- implements ExplicitlyCastableSignature {
+ implements ExplicitlyCastableSignature, NullToNonNullFunction {
Review Comment:
**Preserve safe pushdown when the separator is null-extended.**
The class-wide marker also blocks safe nullable-separator cases. For
`count(concat_ws(t2.name, 'x'))` over a LEFT JOIN, the generated unmatched row
makes child 0 (the separator) NULL, so `concat_ws` is NULL and contributes
nothing; pre-aggregating the right side is therefore safe. This marker still
sets the context-wide flag and clears `toRight`, which can make the join
consume every duplicate `t2` row instead of one aggregate row per `id2`. Please
make the guard aware of whether the separator remains NULL under the current
side's null extension, while continuing to block non-NULL literals and wrappers
such as `coalesce(t2.name, ',')`, and add a positive nullable-separator
boundary test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
