eldenmoon commented on code in PR #16335:
URL: https://github.com/apache/doris/pull/16335#discussion_r1093097861
##########
gensrc/thrift/Types.thrift:
##########
@@ -92,13 +92,16 @@ enum TPrimitiveType {
DECIMAL128I,
JSONB,
UNSUPPORTED
+ DECIMAL128,
+ VARIANT,
}
enum TTypeNodeType {
SCALAR,
ARRAY,
MAP,
- STRUCT
+ STRUCT,
+ VARIANT = 100,
Review Comment:
strange
##########
fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java:
##########
@@ -678,7 +678,7 @@ public class SessionVariable implements Serializable,
Writable {
// 1. read related rowids along with necessary column data
// 2. spawn fetch RPC to other nodes to get related data by sorted rowids
@VariableMgr.VarAttr(name = ENABLE_TWO_PHASE_READ_OPT)
- public boolean enableTwoPhaseReadOpt = true;
+ public boolean enableTwoPhaseReadOpt = false;
Review Comment:
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
