github-actions[bot] commented on code in PR #68154: URL: https://github.com/apache/doris/pull/68154#discussion_r4044444647
########## regression-test/suites/query_p0/insert_into_table/test_insert_array_struct_function_signature.groovy: ########## @@ -0,0 +1,52 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +suite("test_insert_array_struct_function_signature") { + sql "drop table if exists array_struct_function_signature" + sql """ + create table array_struct_function_signature ( + id int, + a array<struct<i: int, s: varchar(16)>> + ) duplicate key(id) + distributed by hash(id) buckets 1 + properties("replication_num" = "1") + """ + + sql "set enable_fast_analyze_into_values = true" Review Comment: **Add failure-sensitive coverage for the new post-bind scopes.** Both statements run through `InsertUtils.normalizePlan` before fast/normal planner selection. Because the target `Cast` is analyzed first, `buildExprAnalyzer.visitCast` already folds `repeat` and rebuilds its `CreateStruct`/`Array` ancestors through the first new preserving helper before `InsertIntoValuesAnalyzer.execute()`. This test therefore still passes if the new phase split at lines 109-118—or the later whole-value helper at `InsertUtils.java:616`—is removed, and it never enters `batchInsert=true`. Please add a focused analyzer case where folding first occurs after sink binding, plus a case for the changed batch job list, so each new scope is actually regression-tested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
