HappenLee commented on code in PR #16474:
URL: https://github.com/apache/doris/pull/16474#discussion_r1098449919
##########
fe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java:
##########
@@ -1130,22 +1130,20 @@ private void computeFragmentExecParams() throws
Exception {
// here choose the first instance to build hash table.
Map<TNetworkAddress, FInstanceExecParam> destHosts = new
HashMap<>();
destParams.instanceExecParams.forEach(param -> {
- if (destHosts.containsKey(param.host)) {
-
destHosts.get(param.host).instancesSharingHashTable.add(param.instanceId);
- return;
- }
- destHosts.put(param.host, param);
-
- param.buildHashTableForBroadcastJoin = true;
- TPlanFragmentDestination dest = new
TPlanFragmentDestination();
- dest.fragment_instance_id = param.instanceId;
- try {
- dest.server = toRpcHost(param.host);
- dest.setBrpcServer(toBrpcHost(param.host));
- } catch (Exception e) {
- throw new RuntimeException(e);
+ if (!destHosts.containsKey(param.host)) {
Review Comment:
forget call `
destHosts.get(param.host).instancesSharingHashTable.add(param.instanceId);`
##########
fe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java:
##########
@@ -1130,22 +1130,20 @@ private void computeFragmentExecParams() throws
Exception {
// here choose the first instance to build hash table.
Map<TNetworkAddress, FInstanceExecParam> destHosts = new
HashMap<>();
destParams.instanceExecParams.forEach(param -> {
- if (destHosts.containsKey(param.host)) {
-
destHosts.get(param.host).instancesSharingHashTable.add(param.instanceId);
- return;
- }
- destHosts.put(param.host, param);
-
- param.buildHashTableForBroadcastJoin = true;
- TPlanFragmentDestination dest = new
TPlanFragmentDestination();
- dest.fragment_instance_id = param.instanceId;
- try {
- dest.server = toRpcHost(param.host);
- dest.setBrpcServer(toBrpcHost(param.host));
- } catch (Exception e) {
- throw new RuntimeException(e);
+ if (!destHosts.containsKey(param.host)) {
Review Comment:
forget call `
destHosts.get(param.host).instancesSharingHashTable.add(param.instanceId);`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
