morningman commented on code in PR #16470:
URL: https://github.com/apache/doris/pull/16470#discussion_r1098381452
##########
be/src/olap/tablet.cpp:
##########
@@ -826,10 +826,9 @@ bool Tablet::can_do_compaction(size_t path_hash,
CompactionType compaction_type)
}
if (tablet_state() == TABLET_NOTREADY) {
- // Before doing schema change, tablet's rowsets that versions smaller
than max converting version will be
- // removed. So, we only need to do the compaction when it is being
converted.
- // After being converted, tablet's state will be changed to
TABLET_RUNNING.
- return SchemaChangeHandler::tablet_in_converting(tablet_id());
+ // In TABLET_NOTREADY, we keep last 10 versions in new tablet so basa
tablet max_version
Review Comment:
```suggestion
// In TABLET_NOTREADY, we keep last 10 versions in new tablet so
base tablet max_version
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
